Use Python Version: let user select architecture as an advanced option #6937
Conversation
brcrista
changed the title
| ].join(EOL); | ||
|
|
||
| assert.strictEqual(e.message, expectedMessage); | ||
| done(); | ||
| } | ||
| }); | ||
|
|
||
| it('selects architecture passed as input', async function () { | ||
| let buildVariables: { [key: string]: string } = {}; |
There was a problem hiding this comment.
It looks like you can make this const.
There was a problem hiding this comment.
Yeah, I've come around to your opinion on this. I'll change this next time I touch this file.
| "required": true, | ||
| "helpMarkDown": "The target architecture (x86, x64) of the Python interpeter.", | ||
| "groupName": "advanced", | ||
| "options": { |
There was a problem hiding this comment.
I am not sure if this is appropriate here, but in most cases with options like this we have a "default" option that is selected automatically and allows the Task to make the most appropriate choice. I.e. choose the one that matches the OS arch.
There was a problem hiding this comment.
See a few lines above, the default is x64. The agent's architecture won't be known at build definition time, but the hosted agents only have x64 Pythons.
There was a problem hiding this comment.
We have the "default" on several picklists (e.g. Java version) to make it just work on any agent but it does cause a lot of confusion. In this case not having "default" is better.
There was a problem hiding this comment.
@jpricketMSFT Sorry, I think I misunderstood you the first time. Sounds like you were talking about "passing null" to the task and letting the task choose at runtime. But I think the best experience is to pass 'x64' unless the user says otherwise.
There was a problem hiding this comment.
Yes that is basically what I was thinking, but as Madhuri says, it can cause a lot of confusion. This is better.
The hosted agents only have 64-bit versions of Python installed, but users are able to install 32-bit versions on private agents. They can also install 32-bit versions on hosted Windows agents from NuGet using the 3rd party "Install Python" task.
Since hosted agents only have 64-bit, I am putting this setting under the "Advanced" tab with a default value of x64. When the task fails to find a version, it will now list versions with architectures available to the agent.
Testing: