Users/rok/telemtry in m123 for older version #6823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoshanKumarMicrosoft
requested review from
kmkumaran,
chshrikh and
KrishnaAdityaB
chshrikh
reviewed
Apr 5, 2018
| @@ -54,6 +54,7 @@ $ErrorActionPreference = 'Stop' | |||
| $deploymentOperation = 'Deployment' | |||
|
|
|||
There was a problem hiding this comment.
please remove all instances of this from this file
Write-Telemetry "DTLSDK_Error" $deploymentResponse.DeploymentSummary"
There was a problem hiding this comment.
Done. @asranja Please review it.
| @@ -13,7 +13,7 @@ | |||
| "version": { | |||
| "Major": 1, | |||
| "Minor": 0, | |||
| "Patch": 47 | |||
| "Patch": 51 | |||
There was a problem hiding this comment.
Why from version 47 to 51 ?
Because we have done hotfix for version 1 from chaitanya branch not through m123. In chaitanya branch last version for PS on target machine is 50 and window file copy is 42.
kmkumaran
approved these changes
Apr 9, 2018
|
Make sure you run a CDP with your change before check-in. |
chshrikh
reviewed
Apr 9, 2018
| @@ -53,6 +53,55 @@ param ( | |||
| [String]$psOnRemoteScriptBlockString = "Invoke-PsOnRemote -MachineDnsName $fqdn -ScriptPath `$scriptPath -WinRMPort $port -Credential `$credential -ScriptArguments `$scriptArguments -InitializationScriptPath `$initializationScriptPath -SessionVariables `$parsedSessionVariables $skipCACheckOption $httpProtocolOption $enableDetailedLoggingOption" | |||
| [scriptblock]$psOnRemoteScriptBlock = [scriptblock]::Create($psOnRemoteScriptBlockString) | |||
| $deploymentResponse = Invoke-Command -ScriptBlock $psOnRemoteScriptBlock | |||
|
|
|||
|
|
|||
| # Telemetry data logic through ps session | |||
There was a problem hiding this comment.
run all our BVT Test before merge
chshrikh
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.