Let "Use Python Version" handle prelease Python versions #6815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashtagchris
approved these changes
Mar 29, 2018
| @@ -31,8 +31,19 @@ interface TaskParameters { | |||
| readonly addToPath: boolean | |||
| } | |||
|
|
|||
| export function pythonVersionToSemantic(versionSpec: string) { | |||
| const prereleaseVersion = /(\d\.\d\.\d)([a|b|rc]\d?)/g; | |||
There was a problem hiding this comment.
Could a, b or rc be followed multiple digits?
There was a problem hiding this comment.
According to the spec for valid version strings yes, but in practice nothing has ever gotten that high. I'll make it more robust just so we don't have to touch it again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python's versioning scheme is compliant with semantic versioning except for its prerelease versions.
Python: 3.7.0b2
Semantic: 3.7.0-b2
Per tool lib, the tool cache must laid out using semantic versions.
This change lets the task work if the user enters the Python-style version instead of the semantic version.
Testing: