Users/suaggar/webdeploytlsguidancemsg #6779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SumiranAgg
added
Area: Release
Area: AzureAppService
vincent1173
reviewed
Mar 23, 2018
| @@ -179,6 +179,7 @@ | |||
| "FailedToApplyTransformationReason1": "1. Whether the Transformation is already applied for the MSBuild generated package during build. If yes, remove the <DependentUpon> tag for each config in the csproj file and rebuild. ", | |||
| "FailedToApplyTransformationReason2": "2. Ensure that the config file and transformation files are present in the same folder inside the package.", | |||
| "AutoParameterizationMessage": "ConnectionString attributes in Web.config is parameterized by default. Note that the transformation has no effect on connectionString attributes as the value is overridden during deployment by 'Parameters.xml or 'SetParameters.xml' files. You can disable the auto-parameterization by setting /p:AutoParameterizationWebConfigConnectionStrings=False during MSBuild package generation.", | |||
| "PackageDeploymentFailed": "Failed to deploy web package to IIS website." | |||
| "PackageDeploymentFailed": "Failed to deploy web package to IIS website.", | |||
| "Updatemachinetoenablesecuretlsprotocol" : "Stronger security protocol might be required. Please make sure the machine is using TLS 1.1 or higher. Check the link for more information https://support.microsoft.com/en-us/help/3206898/enabling-iis-manager-and-web-deploy-after-disabling-ssl3-and-tls-1-0" | |||
There was a problem hiding this comment.
Changed error message
| @@ -195,6 +195,9 @@ export function redirectMSDeployErrorToConsole() { | |||
| else if(errorFileContent.indexOf("FILE_IN_USE") !== -1) { | |||
| tl.warning(tl.loc("Trytodeploywebappagainwithrenamefileoptionselected")); | |||
| } | |||
| else if(errorFileContent.indexOf("Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host.") != -1){ | |||
There was a problem hiding this comment.
Can we reduce the length of the hard-coded message?
There was a problem hiding this comment.
parsing just keyword now
kmkumaran
reviewed
Mar 23, 2018
| @@ -179,6 +179,7 @@ | |||
| "FailedToApplyTransformationReason1": "1. Whether the Transformation is already applied for the MSBuild generated package during build. If yes, remove the <DependentUpon> tag for each config in the csproj file and rebuild. ", | |||
| "FailedToApplyTransformationReason2": "2. Ensure that the config file and transformation files are present in the same folder inside the package.", | |||
| "AutoParameterizationMessage": "ConnectionString attributes in Web.config is parameterized by default. Note that the transformation has no effect on connectionString attributes as the value is overridden during deployment by 'Parameters.xml or 'SetParameters.xml' files. You can disable the auto-parameterization by setting /p:AutoParameterizationWebConfigConnectionStrings=False during MSBuild package generation.", | |||
| "PackageDeploymentFailed": "Failed to deploy web package to IIS website." | |||
| "PackageDeploymentFailed": "Failed to deploy web package to IIS website.", | |||
| "Updatemachinetoenablesecuretlsprotocol" : "Stronger security protocol might be required. Please make sure the machine is using TLS 1.1 or higher. Check the link for more information https://support.microsoft.com/en-us/help/3206898/enabling-iis-manager-and-web-deploy-after-disabling-ssl3-and-tls-1-0" | |||
There was a problem hiding this comment.
Can we keep this as forward link. That will help us to redirect to a different link (if required) later.
There was a problem hiding this comment.
replaced by forward link
kmkumaran
approved these changes
Mar 26, 2018
vincent1173
approved these changes
Mar 26, 2018
SumiranAgg
added a commit
that referenced
this pull request
Mar 26, 2018
This reverts commit 0fb6f81.
SumiranAgg
added a commit
that referenced
this pull request
Mar 26, 2018
* ms deploy guidance message for TLS support * error message change * addressing PR comments
SumiranAgg
added a commit
that referenced
this pull request
Mar 27, 2018
* Users/suaggar/webdeploytlsguidancemsg (#6779) * ms deploy guidance message for TLS support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidance message for TLS error in web deploy