Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for taking TestRun title into consideration while publishing results #6758

Merged
merged 3 commits into from
Mar 21, 2018

Conversation

khilangoel
Copy link
Contributor

Adding Test Run title while publishing results

Fixes: #6588

…lts.

Adding Test Run title while publishing results

Fixes: microsoft#6588
@khilangoel
Copy link
Contributor Author

@madhurig Please can you look into the PR

Copy link
Contributor

@madhurig madhurig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one comment

@@ -16,7 +16,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 131,
"Minor": 132,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the "Minor" version to 133 to match the current VSTS sprint (133 goes from 3/19 to 4/6). When you build the task it will generate a task.loc.json file. Please commit that as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Please merge this PR if changes looks fine. If there are any other things I need to do, please tell me

@madhurig
Copy link
Contributor

@khilan2goel: Thank you for the contribution!

@madhurig madhurig merged commit f3eaac9 into microsoft:master Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants