msi for native support #6655
Merged
msi for native support #6655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can't go with Add-AzureRmAccount -MSI approach this feature is only available from 5.5.0. But in our case if vm is MSI enabled then it has backward compatibility as well. So going with token approach. |
kmkumaran
reviewed
Apr 8, 2018
Tasks/AzurePowerShell/Utility.ps1
Outdated
| @@ -30,7 +30,7 @@ function Update-PSModulePathForHostedAgent { | |||
| $hostedAgentAzureModulePath = Get-LatestModule -patternToMatch "^azure_[0-9]+\.[0-9]+\.[0-9]+$" -patternToExtract "[0-9]+\.[0-9]+\.[0-9]+$" -Classic:$true | |||
| } | |||
|
|
|||
| if($authScheme -eq 'ServicePrincipal' -or $authScheme -eq '') | |||
| if($authScheme -eq 'ServicePrincipal' -or $authScheme -eq '' -or $authScheme -eq 'ManagedServiceIdentity') | |||
There was a problem hiding this comment.
Would be good to move the empty check to the end.
| $port = $Endpoint.Data.MsiPort | ||
| } | ||
| $msiUri = "http://localhost:$port/oauth2/token" | ||
| $response = Invoke-WebRequest -Uri $msiUri -Method GET -Body @{resource= $Endpoint.Url} -Headers @{Metadata="true"} -UseBasicParsing |
There was a problem hiding this comment.
All these logic has to change.
| throw (New-Object System.Exception((Get-VstsLocString -Key AZ_ManagedServiceIdentityError), $_.Exception)) | ||
| } | ||
|
|
||
| Set-CurrentAzureRMSubscription -SubscriptionId $Endpoint.Data.SubscriptionId -TenantId $Endpoint.Auth.Parameters.TenantId |
There was a problem hiding this comment.
Can you merge with latest changes for TLS done by Rajat.
kmkumaran
approved these changes
Apr 13, 2018
| } | ||
| catch | ||
| { | ||
| $exceptionMessage = $_.Exception.Message.ToString() |
There was a problem hiding this comment.
@Ajay-MS - Can you ensure post Roshan's change, your changes to log the error code is factored in.
There was a problem hiding this comment.
Will take into separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.