Added secrets section in Kubernetes Task #6611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bansalaseem
reviewed
Mar 6, 2018
| "loc.group.displayName.advanced": "Advanced", | ||
| "loc.group.displayName.output": "Output", | ||
| "loc.input.label.kubernetesServiceEndpoint": "Kubernetes Service Connection", | ||
| "loc.input.help.kubernetesServiceEndpoint": "Select a Kubernetes service connection.", | ||
| "loc.input.label.namespace": "Namespace", |
There was a problem hiding this comment.
As discussed with Atul ,the commands and secrets section use the same namespace field so it would be more readable if the namespace field is moved just below the kubernetes service connection field.
bansalaseem
reviewed
Mar 6, 2018
| } | ||
| } | ||
|
|
||
| function deleteSecret(connection: ClusterConnection, secret: string): any { | ||
| tl.debug(tl.loc('DeleteSecret', secret)); | ||
| var command = connection.createCommand(); | ||
| command.arg(getNameSpace()); |
bansalaseem
reviewed
Mar 6, 2018
|
|
||
| if(authenticationToken) | ||
| { | ||
| tl.debug(tl.loc('CreatingSecret', secret)); | ||
| var command = connection.createCommand(); | ||
| command.arg(getNameSpace()); |
bansalaseem
reviewed
Mar 6, 2018
| @@ -47,6 +47,14 @@ | |||
| "label": "Kubernetes Service Connection", | |||
| "helpMarkDown": "Select a Kubernetes service connection." | |||
| }, | |||
| { | |||
| "name": "namespace", | |||
bansalaseem
reviewed
Mar 6, 2018
| "name": "namespace", | ||
| "type": "string", | ||
| "label": "Namespace", | ||
| "required": false, |
There was a problem hiding this comment.
why this change? Please undo it
bansalaseem
suggested changes
Mar 6, 2018
jikuma
reviewed
Mar 6, 2018
| "defaultValue": "", | ||
| "groupName": "registry" | ||
| "groupName": "secrets" |
There was a problem hiding this comment.
Changing group of an old input will not break the old task right?. Have we verified it.
There was a problem hiding this comment.
Yes, i have verified. The task will run the same
Anumita
force-pushed
the
users/ansheno/kubernetesSecretsSection
branch
2 times, most recently
from
f4874d2 to
2578ff7
Compare
bansalaseem
approved these changes
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker registry secret
Generic secret
