add default params for MSDEPLOY #6527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent1173
added
Area: Release
Area: AzureAppService
Ajay-MS
reviewed
Feb 26, 2018
| @@ -0,0 +1,112 @@ | |||
| var msdeployUtility = require('webdeployment-common/msdeployutility.js'); | |||
| /*getMSDeployCmdArgs(webAppPackage: string, webAppName: string, publishingProfile, | |||
Ajay-MS
approved these changes
Feb 27, 2018
kmkumaran
reviewed
Feb 28, 2018
| } | ||
|
|
||
| additionalArguments = !!(additionalArguments) ? additionalArguments : ' '; |
There was a problem hiding this comment.
Instead of all these, why can't we just add the default values in the task.json for "additionalArguments" input? The task code will handle them as just another additional arguments input. This will be transparent as user know the values with which msdeploy is being run. User has flexibility to update the default values if required.
There was a problem hiding this comment.
Updated the value based on the discussion.
kmkumaran
approved these changes
Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.