Added L0 test cases for kubernetes #6494

Anumita · 2018-02-21T19:12:04Z

No description provided.

jikuma · 2018-02-22T04:35:29Z

Tasks/Kubernetes/Tests/TestSetup.ts

+fsClone.existsSync = function(filePath) {
+    switch (filePath) {
+        case "kubectl":
+            if(JSON.parse(process.env[shared.isKubectlPresentOnMachine]))


why JSON.parse

jikuma · 2018-02-22T04:37:58Z

Tasks/Kubernetes/Tests/L0.ts

+    });
+
+    it('Run sucessfully when the user provides the version for kubectl with checkLatest as false', (done:MochaDone) => {
+        let tp = path.join(__dirname, 'TestSetup.js');


There is no check, in the test that kubectl is downloaded and version 1.7 is downloaded.

applied check

jikuma · 2018-02-22T04:39:40Z

Tasks/Kubernetes/Tests/L0.ts

+        assert(tr.invokedToolCount == 1, 'should have invoked tool one times. actual: ' + tr.invokedToolCount);
+        assert(tr.stderr.length == 0 || tr.errorIssues.length, 'should not have written to stderr');
+        assert(tr.succeeded, 'task should have succeeded');
+        assert(tr.stdout.indexOf(`[command]${shared.formatPath("newUserDir/kubectl.exe")} --kubeconfig ${shared.formatPath("newUserDir/config")} get pods`) != -1, "kubectl apply should run");


command you are trying to run is get pods not apply. Please fix the message.

Fixed message

jikuma · 2018-02-22T04:40:26Z

Tasks/Kubernetes/Tests/L0.ts

+    });
+
+    it('Run sucessfully when the user provides the version for kubectl with checkLatest as true', (done:MochaDone) => {
+        let tp = path.join(__dirname, 'TestSetup.js');


I can not see any check that latest version is looked for and downloded.

Added check

jikuma · 2018-02-22T04:42:23Z

Tasks/Kubernetes/Tests/L0.ts

+        assert(tr.invokedToolCount == 1, 'should have invoked tool one times. actual: ' + tr.invokedToolCount);
+        assert(tr.stderr.length == 0 || tr.errorIssues.length, 'should not have written to stderr');
+        assert(tr.succeeded, 'task should have succeeded');
+        assert(tr.stdout.indexOf(`[command]${shared.formatPath("newUserDir/kubectl.exe")} --kubeconfig ${shared.formatPath("newUserDir/config")} get pods`) != -1, "kubectl apply should run");


command is get pods and message is apply. This error is in all test please fix it.

jikuma · 2018-02-22T04:44:21Z

Tasks/Kubernetes/Tests/L0.ts

+    after(function () {
+    });
+
+    it('Run sucessfully when the user provides a specific location for kubectl', (done:MochaDone) => {


type in sucessfully => successfully in every test.

jikuma · 2018-02-22T04:50:48Z

Tasks/Kubernetes/Tests/L0.ts

+        assert(tr.invokedToolCount == 1, 'should have invoked tool one times. actual: ' + tr.invokedToolCount);
+        assert(tr.stderr.length == 0 || tr.errorIssues.length, 'should not have written to stderr');
+        assert(tr.succeeded, 'task should have succeeded');
+        assert(tr.stdout.indexOf(`[command]${shared.formatPath("newUserDir/kubectl.exe")} --kubeconfig ${shared.formatPath("newUserDir/config")} get pods`) != -1, "kubectl apply should run");


I think you copied the checks in output section as is in all test cases. There is no check to validate that, tests are running the way they are expected. Tests might succeed but does not execute the way they are supposed to.

jikuma · 2018-02-22T04:52:01Z

Tasks/Kubernetes/Tests/L0.ts

+        done();
+    });
+
+    it('Runs successfully for kubectl exec', (done:MochaDone) => {


We dont have to add test cases for each command.

Removed duplicate test cases

jikuma · 2018-02-22T04:54:26Z

Tasks/Kubernetes/Tests/L0.ts

+        done();
+    });
+
+    it('Runs successfully for kubectl top', (done:MochaDone) => {


same comment, tests for each command is duplicate.

Removed duplicate test cases

jikuma · 2018-02-22T04:57:06Z

Tasks/Kubernetes/Tests/TestSetup.ts

+        return "v1.6.6";
+    },
+    getKubectlVersion: async function(versionSpec, checkLatest) : Promise<string> {
+        let version: string = "v1.6.6";   


We should avoid having logic in mocq.

Need to add the logic as the mock getStableKubectlVersion() will not be called if we use the original getKubectlVersion().

jikuma · 2018-02-23T05:12:05Z

Tasks/Kubernetes/Tests/L0.ts

+        assert(tr.succeeded, 'task should have succeeded');
+        assert(tr.stdout.indexOf(`Get stable kubectl version`) != -1, "Stable version of kubectl is downloaded");
+        assert(tr.stdout.indexOf(`Got kubectl version v1.6.6`) != -1, "Got the latest version of kubectl");
+        assert(tr.stdout.indexOf(`Downloaded kubectl`) != -1, "Downloaded correct version of kubectl");


We should check that the version is 1.7.0 and not anything else. I am pushing hard to have our test correct because it will help us in future to push update fast and not have to test on windows and linux separately.

jikuma · 2018-02-23T05:12:41Z

Tasks/Kubernetes/Tests/L0.ts

+        assert(tr.stderr.length == 0 || tr.errorIssues.length, 'should not have written to stderr');
+        assert(tr.succeeded, 'task should have succeeded');
+        assert(tr.stdout.indexOf(`Get stable kubectl version`) != -1, "Stable version of kubectl is downloaded");
+        assert(tr.stdout.indexOf(`Got kubectl version v1.6.6`) != -1, "Got the latest version of kubectl");


Why does output contains 'Got kubectl version v1.6.6', it should be 1.7.0

When version is 1.7 we check for the stable latest version which is 1.6.6

jikuma · 2018-02-23T05:15:32Z

Tasks/Kubernetes/Tests/L0.ts

+        assert(tr.invokedToolCount == 2, 'should have invoked tool one times. actual: ' + tr.invokedToolCount);
+        assert(tr.stderr.length == 0 || tr.errorIssues.length, 'should not have written to stderr');
+        assert(tr.succeeded, 'task should have succeeded');
+        assert(tr.stdout.indexOf(`[command]kubectl --kubeconfig ${shared.formatPath("newUserDir/config")} create secret docker-registry my-secret --docker-server=https://index.docker.io/v1/ --docker-username=test --docker-password=regpassword [email protected]`) != -1, "kubectl create should run");


there is no check of forceUpdate here?

added check for delete secret

jikuma · 2018-02-23T05:16:42Z

Tasks/Kubernetes/Tests/L0.ts

+        assert(tr.invokedToolCount == 2, 'should have invoked tool one times. actual: ' + tr.invokedToolCount);
+        assert(tr.stderr.length == 0 || tr.errorIssues.length, 'should not have written to stderr');
+        assert(tr.succeeded, 'task should have succeeded');
+        assert(tr.stdout.indexOf(`[command]kubectl --kubeconfig ${shared.formatPath("newUserDir/config")} create secret docker-registry my-secret --docker-server=ajgtestacr1.azurecr.io --docker-username=spId --docker-password=spKey --docker-email=ServicePrincipal@AzureRM`) != -1, "kubectl create should run");


Again no mention of force update in the command.

…downloaded

…ubernetes

Added L0 test cases for kubernetes

c209d00

Anumita requested review from jikuma and bansalaseem February 21, 2018 19:12

jikuma requested changes Feb 22, 2018

View reviewed changes

kmkumaran assigned bansalaseem Feb 22, 2018

kmkumaran added the Area: Release label Feb 22, 2018

Removed unnecessary test cases and resolved comments for kubernetes

ae6db89

jikuma reviewed Feb 23, 2018

View reviewed changes

jikuma approved these changes Feb 26, 2018

View reviewed changes

Anumita added 2 commits February 26, 2018 13:59

Added check for forceUpdate and for the version of kubectl that gets …

ea71d08

…downloaded

Reverted change for kubectlPath in downloadKubectl for test case in K…

5b1c612

…ubernetes

Anumita force-pushed the users/ansheno/kubernetesTestCases branch from 84e2301 to 5b1c612 Compare February 26, 2018 13:21

Anumita merged commit cc04156 into master Feb 27, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added L0 test cases for kubernetes #6494

Added L0 test cases for kubernetes #6494

Anumita commented Feb 21, 2018

jikuma Feb 22, 2018

jikuma Feb 22, 2018

Anumita Feb 22, 2018

jikuma Feb 22, 2018

Anumita Feb 22, 2018

jikuma Feb 22, 2018

Anumita Feb 22, 2018

jikuma Feb 22, 2018

Anumita Feb 22, 2018

jikuma Feb 22, 2018

Anumita Feb 22, 2018

jikuma Feb 22, 2018

jikuma Feb 22, 2018

Anumita Feb 22, 2018

jikuma Feb 22, 2018

Anumita Feb 22, 2018

jikuma Feb 22, 2018

Anumita Feb 22, 2018

jikuma Feb 23, 2018

Anumita Feb 26, 2018

jikuma Feb 23, 2018

Anumita Feb 26, 2018

jikuma Feb 23, 2018

Anumita Feb 26, 2018

jikuma Feb 23, 2018

Anumita Feb 26, 2018

Added L0 test cases for kubernetes #6494

Added L0 test cases for kubernetes #6494

Conversation

Anumita commented Feb 21, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment