Added support for custom certificates #6467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eating new Azure Cloud Service
|
I took a look at PR today. Overall logic seems fine to me. I will test the task and will approve changes. |
|
Did you have the chance to test the task so far? |
|
I apologize for being a delay in this. I have done testing with few of scenario's but not completed. I will do remaining testing and merge this PR by this weekend. |
Ajay-MS
approved these changes
Mar 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the issue #6418 which aims to add support for adding custom certificates to the Azure Cloud Service when the VSTS task AzureCloudPowerShellDeployment creates a new ACS.
Known issues: Translation of resource strings to all languages besides en-US is not yet provided, thus the necessary resource strings are imported to all localized resource files "as is" (i.e. in English language). Should you direct me to a translation service, I will add the translations as well.