App Service Deploy 4.* Task Version (Preview) #6422
Conversation
vincent1173
commented
Feb 13, 2018
•
vincent1173
commented
- Update Help markdown
vincent1173
requested review from
kmkumaran,
pavanadepu2,
Ajay-MS,
sachinma,
asranja,
dikhakha and
aydey
vincent1173
added
Area: Release
Area: AzureAppService
| "Patch": 42 | ||
| "Major": 4, | ||
| "Minor": 0, | ||
| "Patch": 0 | ||
| }, | ||
| "releaseNotes": "What's new in Version 3.0: <br/> Supports File Transformations (XDT) <br/> Supports Variable Substitutions(XML, JSON) <br/>Click [here](https://aka.ms/azurermwebdeployreadme) for more Information.", |
There was a problem hiding this comment.
Release notes has to be updated with latest breaking change details. Work with PM on this.
| @@ -25,13 +26,13 @@ | |||
| "name": "FileTransformsAndVariableSubstitution", | |||
| "displayName": "File Transforms & Variable Substitution Options", | |||
| "isExpanded": false, | |||
| "visibleRule": "WebAppKind != linux && WebAppKind != applinux && WebAppKind != \"\"" | |||
| "visibleRule": "WebAppKind != app44linux && WebAppKind != app44linux44container && WebAppKind != \"\"" | |||
There was a problem hiding this comment.
the key app44linux has to be changed based on the mail conversation we have had with @azooinmyluggage
| "app": "Web App", | ||
| "applinux": "Linux Web App", | ||
| "app": "Web App on Windows", | ||
| "app44linux": "Web App on Linux with built-In Images", |
There was a problem hiding this comment.
Is the word 'built-In' used in Azure portal as well? also check for casing - b is small but I is caps.
| "applinux": "Linux Web App", | ||
| "app": "Web App on Windows", | ||
| "app44linux": "Web App on Linux with built-In Images", | ||
| "app44linux44container": "Web App for Containers with Container Registry", |
There was a problem hiding this comment.
Check this with PMs. There are multiple Containers in the label...
| @@ -22,7 +22,7 @@ export class ContainerBasedDeploymentUtility { | |||
| } | |||
|
|
|||
| public async deployWebAppImage(taskParameters: TaskParameters): Promise<void> { | |||
| var imageName = this._getImageName(); | |||
| let imageName: string = this._getDockerHubImageName(); | |||
There was a problem hiding this comment.
@jikuma - Can you review the changes related container deployment.
| StartupCommand: tl.getInput('StartupCommand', false), | ||
| WebAppUri: tl.getInput('WebAppUri', false), | ||
| ConfigurationSettings: tl.getInput('ConfigurationSettings', false) | ||
| } | ||
|
|
||
| taskParameters.WebAppKind = taskParameters.WebAppKind.replace(/44/g, ','); |
There was a problem hiding this comment.
This might changed based on feedback from @azooinmyluggage
| @@ -22,7 +22,7 @@ export class ContainerBasedDeploymentUtility { | |||
| } | |||
|
|
|||
| public async deployWebAppImage(taskParameters: TaskParameters): Promise<void> { | |||
| var imageName = this._getImageName(); | |||
| let imageName: string = this._getDockerHubImageName(); | |||
There was a problem hiding this comment.
Since we are jumping task major version here. There is an opportunity for us to bring docker tasks and azure web app task in sync with how they take image name as input. in Docker tasks there is only one input image name which includes repository name and tag while azure weapp task takes them separately.
There was a problem hiding this comment.
I thought the reason these are separate is because at some point we want to enable drop down for each of these inputs, which will not be possible if we take them as a single input.
