Update empty value in XML Variable substitution #6367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent1173
added
Area: Release
Area: AzureAppService
kmkumaran
approved these changes
Feb 6, 2018
Ajay-MS
reviewed
Feb 6, 2018
|
|
||
| if(xmlDomNode.getAttr(attributeName)) { | ||
| let isValueReplaced: boolean = false; | ||
| if(xmlDomNode.getAttr(attributeName) != undefined) { |
There was a problem hiding this comment.
Does LTX provide method hasAttribute ?? If yes, we should use that method.
There was a problem hiding this comment.
It doesnt have hasAttributes.
Calling xmlDomNode.attrs provides the list of attributes present, from that we need to query for value attribute.
getAttr can be used to achieve the same result.
There was a problem hiding this comment.
I am not in favor of introducing isValueReplaced variable as the same thing can be achieved without that. ( Will discuss offline)
There was a problem hiding this comment.
Planned to address the case, where the element has no value attribute and children with no value tag.
Ajay-MS
approved these changes
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.