Fix Virtual Application post deployment script #6350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent1173
added
Area: Release
Area: AzureAppService
| try { | ||
| directoryPath = (!!directoryPath) ? directoryPath : physicalRootPath.substring(1); |
There was a problem hiding this comment.
what does physicalRootPath.substring(1) do?
There was a problem hiding this comment.
In api/command API, we pass the command and the path (where we need to run ).
Path shouldn't contain forward slash, if it contains then it considered as absolute path in Linux.
physicalRootPath contains slash prefix and we are removing it.
rajatagrawal-dev
approved these changes
Feb 2, 2018
kmkumaran
approved these changes
Feb 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post deployment scripts were executed in root path instead of virtual path, when provided.
This fails the CDP tests.