Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix copying compressed pkg issue #6347

Merged
merged 2 commits into from
Feb 2, 2018
Merged

fix copying compressed pkg issue #6347

merged 2 commits into from
Feb 2, 2018

Conversation

BinWuMSFT
Copy link
Contributor

If "(pkgName).zip" exists, copy it to the diff package, else copy "(pkgName)" folder

@@ -142,6 +142,14 @@ function Copy-DiffPackage

$localPkgPath = Join-Path $localParentPkgPath $localPackage.Name
$diffPkgPath = Join-Path $diffParentPkgPath $localPackage.Name
$localZipPkgPath = $localPkgPath + ".zip"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new variables are not really necessary. you can directly use $localPkgPath + ".zip" later.

Copy link
Member

@NCarlsonMSFT NCarlsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also update the test to add a zip that should be copied and asserts for both copying and not copying a zip?

Copy link
Member

@NCarlsonMSFT NCarlsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@BinWuMSFT BinWuMSFT merged commit 33fb4d3 into master Feb 2, 2018
@starkmsu starkmsu deleted the dev/binwu/diffPkgFix branch July 14, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants