Added check for Linux App Type #6310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent1173
added
Area: Release
Area: AzureAppService
Ajay-MS
reviewed
Jan 30, 2018
| @@ -289,7 +289,7 @@ | |||
| "label": "Package or folder", | |||
| "defaultValue": "$(System.DefaultWorkingDirectory)/**/*.zip", | |||
| "required": true, | |||
| "visibleRule": "WebAppKind = applinux && ImageSource = Builtin", | |||
| "visibleRule": "WebAppKind != app && WebAppKind != functionapp && WebAppKind != api && WebAppKind != mobileapp && ImageSource = Builtin", | |||
There was a problem hiding this comment.
The visible rule will be true for some unknown app type. Consider it would not break existing users.
There was a problem hiding this comment.
agreed. unless user changes the App Type to some invalid name, this will hold.
Also, we would be moving to new task major version soon and this will be taken care.
Will add a story on the backlog. 👍
Ajay-MS
approved these changes
Jan 30, 2018
pavanadepu2
approved these changes
Jan 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.