Users/kej/handlebackslashproperly #6288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhurig
reviewed
Jan 25, 2018
| // Now matching the pattern against all files | ||
| var uploadFilesList = tl.match(allFiles, filesPattern, undefined, {matchBase: true}); | ||
| var uploadFilesList = tl.match(allFiles, filesPattern, undefined, {matchBase: true}).map( (s) => { |
There was a problem hiding this comment.
Please add a comment on why we had to do this.
madhurig
approved these changes
Jan 25, 2018
lkillgore
approved these changes
Jan 25, 2018
…in linux environments
keljos
added a commit
that referenced
this pull request
Jan 25, 2018
* Fix for the backslash escaping issue in cURL * Corrected minor version * Added comment to explain why we are escaping the backslash character in linux environments
keljos
added a commit
that referenced
this pull request
Jan 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the issue where curl is treating backslashes in file paths/names as escape characters.