Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the console code page to "UTF-8" #6274

Merged
merged 7 commits into from
Mar 20, 2018
Merged

Set the console code page to "UTF-8" #6274

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
32abc59
set the console code page to "UTF-8"
thesattiraju Jan 23, 2018
711207d
Merge branch 'master' of https://github.com/Microsoft/vsts-tasks into…
thesattiraju Jan 23, 2018
92a564b
Merge fix
thesattiraju Jan 23, 2018
57a4195
Some more changes
thesattiraju Feb 21, 2018
9813ec9
Merge branch 'master' of https://github.com/Microsoft/vsts-tasks into…
thesattiraju Feb 21, 2018
b71083d
Version bump up
thesattiraju Feb 21, 2018
17432c5
Merge branch 'master' of https://github.com/Microsoft/vsts-tasks into…
thesattiraju Mar 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Tasks/DotNetCoreCLI/Strings/resources.resjson/en-US/resources.resjson
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@
"loc.input.label.workingDirectory": "Working Directory",
"loc.input.help.workingDirectory": "Current working directory where the script is run. Empty is the root of the repo (build) or artifacts (release), which is $(System.DefaultWorkingDirectory)",
"loc.messages.BuildIdentityPermissionsHint": "For internal feeds, make sure the build service identity '%s' [%s] has access to the feed.",
"loc.messages.CouldNotSetCodePaging": "Could not set the code paging of due to following error: %s",
"loc.messages.Error_AutomaticallyVersionReleases": "Autoversion: Getting version number from build option is not supported in releases",
"loc.messages.Error_CommandNotRecognized": "The command %s was not recognized.",
"loc.messages.Error_NoSourceSpecifiedForPush": "No source was specified for push",
Expand Down
13 changes: 13 additions & 0 deletions Tasks/DotNetCoreCLI/dotnetcore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export class dotNetExe {

public async execute() {
tl.setResourcePath(path.join(__dirname, "task.json"));
this.setConsoleCodePage();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this actually be handled in task-lib?


switch (this.command) {
case "build":
Expand Down Expand Up @@ -58,6 +59,18 @@ export class dotNetExe {
}
}

private setConsoleCodePage() {
// set the console code page to "UTF-8"
if (tl.osType() === 'Windows_NT') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, does it need to be done in other tasks where we are invoking exes like az cli, packer

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any exception thrown from this should be ignored with a warning

try {
tl.execSync(path.resolve(process.env.windir, "system32", "chcp.com"), ["65001"]);
}
catch (ex) {
tl.warning(tl.loc("CouldNotSetCodePaging", JSON.stringify(ex)))
}
}
}

private async executeBasicCommand() {
var dotnetPath = tl.which("dotnet", true);

Expand Down
3 changes: 2 additions & 1 deletion Tasks/DotNetCoreCLI/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"version": {
"Major": 2,
"Minor": 131,
"Patch": 0
"Patch": 1
},
"minimumAgentVersion": "2.0.0",
"instanceNameFormat": "dotnet $(command)",
Expand Down Expand Up @@ -471,6 +471,7 @@
},
"messages": {
"BuildIdentityPermissionsHint": "For internal feeds, make sure the build service identity '%s' [%s] has access to the feed.",
"CouldNotSetCodePaging": "Could not set the code paging of due to following error: %s",
"Error_AutomaticallyVersionReleases": "Autoversion: Getting version number from build option is not supported in releases",
"Error_CommandNotRecognized": "The command %s was not recognized.",
"Error_NoSourceSpecifiedForPush": "No source was specified for push",
Expand Down
3 changes: 2 additions & 1 deletion Tasks/DotNetCoreCLI/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"version": {
"Major": 2,
"Minor": 131,
"Patch": 0
"Patch": 1
},
"minimumAgentVersion": "2.0.0",
"instanceNameFormat": "ms-resource:loc.instanceNameFormat",
Expand Down Expand Up @@ -471,6 +471,7 @@
},
"messages": {
"BuildIdentityPermissionsHint": "ms-resource:loc.messages.BuildIdentityPermissionsHint",
"CouldNotSetCodePaging": "ms-resource:loc.messages.CouldNotSetCodePaging",
"Error_AutomaticallyVersionReleases": "ms-resource:loc.messages.Error_AutomaticallyVersionReleases",
"Error_CommandNotRecognized": "ms-resource:loc.messages.Error_CommandNotRecognized",
"Error_NoSourceSpecifiedForPush": "ms-resource:loc.messages.Error_NoSourceSpecifiedForPush",
Expand Down