Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AzureRGDeployment] Updating api-version for cross resource group deployment #4648

Merged
merged 1 commit into from
Jun 27, 2017
Merged

[AzureRGDeployment] Updating api-version for cross resource group deployment #4648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tasks/AzureResourceGroupDeployment/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"version": {
"Major": 2,
"Minor": 1,
"Patch": 8
"Patch": 9
},
"demands": [],
"minimumAgentVersion": "2.0.0",
Expand Down
2 changes: 1 addition & 1 deletion Tasks/AzureResourceGroupDeployment/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"version": {
"Major": 2,
"Minor": 1,
"Patch": 8
"Patch": 9
},
"demands": [],
"minimumAgentVersion": "2.0.0",
Expand Down
2 changes: 1 addition & 1 deletion Tasks/Common/azure-arm-rest/azure-arm-resource.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export class ResourceManagementClient extends azureServiceClient.ServiceClient {
constructor(credentials: msRestAzure.ApplicationTokenCredentials, subscriptionId: string, options?: any) {
super(credentials, subscriptionId);

this.apiVersion = '2016-07-01';
this.apiVersion = '2017-05-10';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the common api version for all calls? Any other side impact of this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the version only for RG REST calls, i.e. Deployments, Creating RG etc to avoid impacting the other rest calls.
I've checked out a few scenarios using this api-version for deployments, they were succeeding

this.acceptLanguage = 'en-US';
this.generateClientRequestId = true;
if (!!options && !!options.longRunningOperationRetryTimeout) {
Expand Down