enabled TIA in multi agent #4596
Conversation
Tested 1) Multi agent in CDP with and without TIA 2) None mode in CDP with and without TIA 30 Multi config mode in CDP with and without TIA
Tasks/VsTest/distributedtest.ts
Outdated
| this.registerAndConfigureAgent(); | ||
| } | ||
|
|
||
| private publishCodeChangesIfRequired(): number{ | ||
| if (this.dtaTestConfig.tiaConfig.tiaEnabled) { |
There was a problem hiding this comment.
if not return. keeps simple #Resolved
There was a problem hiding this comment.
removed return. it shuld be simple now #Resolved
Tasks/VsTest/distributedtest.ts
Outdated
| this.registerAndConfigureAgent(); | ||
| } | ||
|
|
||
| private publishCodeChangesIfRequired(): number{ | ||
| if (this.dtaTestConfig.tiaConfig.tiaEnabled) { | ||
| let testselector = new testselectorinvoker.TestSelectorInvoker(); |
There was a problem hiding this comment.
you can directly import the class or use alias #Resolved
There was a problem hiding this comment.
used
const testSelectorInvoker = new testselectorinvoker.TestSelectorInvoker(); #Resolved
Tasks/VsTest/distributedtest.ts
Outdated
| private publishCodeChangesIfRequired(): number{ | ||
| if (this.dtaTestConfig.tiaConfig.tiaEnabled) { | ||
| let testselector = new testselectorinvoker.TestSelectorInvoker(); | ||
| let code = testselector.publishCodeChanges(this.dtaTestConfig.tiaConfig, null); //todo: enable custom engine |
There was a problem hiding this comment.
if argument is not mandatory. mark it as optional so that you don't have to pass null #Resolved
Tasks/VsTest/settingshelper.ts
Outdated
| const testSettingsTemplate = '<?xml version=\"1.0\" encoding=\"UTF-8\"?>' + | ||
| '<TestSettings name=\"testSettings-5d76a195-1e43-4b90-a6ce-4ec3de87ed25\" id=\"5d76a195-1e43-4b90-a6ce-4ec3de87ed25\" xmlns=\"http://microsoft.com/schemas/VisualStudio/TeamTest/2010\">' + |
There was a problem hiding this comment.
write xml content like this. no need + and escape crap
`<XML>
<ABC/>
</XML>
`
``` #Resolved
There was a problem hiding this comment.
thanks 👍 #Closed
Tasks/VsTest/settingshelper.ts
Outdated
| @@ -100,15 +102,31 @@ export async function updateSettingsFileAsRequired(settingsFile: string, isParal | |||
| } | |||
| } | |||
|
|
|||
| if(isDistributedRun && tiaConfig.tiaEnabled){ | |||
| let baseLineRunId = utils.Helper.readFileContentsSync(tiaConfig.baseLineBuildIdFile, 'utf-8'); | |||
| if (settingsExt === testSettingsExt) { | |||
There was a problem hiding this comment.
can this be more meaningful? #Resolved
Tasks/VsTest/settingshelper.ts
Outdated
| } else { | ||
| if (!isDataCollectorPresent(dataCollectorArray, dataCollectorFriendlyName)) { | ||
| tl.debug('Updating testsettings file, adding a DataCollector node'); | ||
| dataCollectorArray.push(dataCollectorNodeToAdd.DataCollector); | ||
| } | ||
| } | ||
| } | ||
| } |
| let sourcesDirectory: string; | ||
| let newprovider = 'true'; | ||
| if (this.getTIALevel(tiaConfig) === 'method') { | ||
| newprovider = 'false'; |
There was a problem hiding this comment.
line 21 #Closed
| }, | ||
| } | ||
|
|
||
| if (!result.RunSettings.RunConfiguration) { |
There was a problem hiding this comment.
if [](start = 4, length = 3)
tried what we have in code coverage enabler but it didnt work. this works. #Closed
|
Fix conflicts. |
Tasks/VsTest/distributedtest.ts
Outdated
| @@ -8,6 +8,9 @@ import * as settingsHelper from './settingshelper'; | |||
| import * as utils from './helpers'; | |||
| import * as ta from './testagent'; | |||
| import * as versionFinder from './versionfinder'; | |||
| import * as testselectorinvoker from './testselectorinvoker'; | |||
|
|
|||
| const testSelector = new testselectorinvoker.TestSelectorInvoker(); | |||
There was a problem hiding this comment.
directly import the class and use alias. this looks aaak :P
Tested