Adding output vars to JenkinsQueueJob task #4585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jpricket
commented
Jun 19, 2017
•
jpricket
commented
- Since output vars require a new version of the agent, I bumped the major version of the task to 2 (this allows the user to choose when to upgrade)
- This is part of internal user story #982063
| @@ -111,6 +111,9 @@ async function doWork() { | |||
| var rootJob = await util.pollCreateRootJob(queueUri, jobQueue, taskOptions); | |||
| //start the job queue | |||
| jobQueue.start(); | |||
| //store the job name in the output variable | |||
| tl.debug('JENKINS_JOB_ID=' + rootJob.executableNumber); | |||
| tl.setVariable("JENKINS_JOB_ID", rootJob.executableNumber.toString()); | |||
There was a problem hiding this comment.
I need to double-check, but I think calling setVariable() already provides debug output.
There was a problem hiding this comment.
Yes, see how the task lib already outputs debug info here.
There was a problem hiding this comment.
Good point. I will remove my extra logging.
Tasks/JenkinsQueueJob/task.json
Outdated
| "outputVariables" : [ | ||
| { | ||
| "name" : "JENKINS_JOB_ID", | ||
| "description" : "The id of the Jenkins Job instance queued by this task. Use this variable in the Jenkins Download task to download the artifacts for this particular job instance." |
There was a problem hiding this comment.
ID should be capitalized. Job should be lowercase. "Jenkins Download task" should be "Jenkins Download Artifacts task".
There was a problem hiding this comment.
Thanks, I will correct these words.
jpricket
force-pushed
the
users/jpricket/jenkins3
branch
from
b1f8402 to
4cf7c42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.