Script tasks #4578
Merged
Script tasks #4578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tasks/powerShell/powershell.ps1
Outdated
| } | ||
|
|
||
| # Get inputs. | ||
| $input_apartment = Get-VstsInput -Name 'apartment' -Default 'Sta' |
There was a problem hiding this comment.
maybe just hard code 'STA'
Tasks/powerShell/powershell.ps1
Outdated
| Write-Error (Get-VstsLocString -Key 'PS_InvalidErrorActionPreference' -ArgumentList $input_errorActionPreference) | ||
| } | ||
| } | ||
| $input_executionPolicy = Get-VstsInput -Name 'executionPolicy' -Default 'Unrestricted' |
Tasks/powerShell/powershell.ps1
Outdated
| Invoke-VstsTool @splat | ||
| } else { | ||
| $global:ErrorActionPreference = 'Continue' | ||
| Invoke-VstsTool @splat 2>&1 | |
There was a problem hiding this comment.
we need ##vso[task.setresult failure];
Tasks/powerShell/powershell.ps1
Outdated
| 'FileName' = $powershellPath | ||
| 'Arguments' = $arguments | ||
| 'WorkingDirectory' = $workingDirectory | ||
| 'RequireExitCodeZero' = !$ignoreExitCode |
Tasks/powerShell/powershell.ps1
Outdated
| $splat = @{ | ||
| 'FileName' = $powershellPath | ||
| 'Arguments' = $arguments | ||
| 'WorkingDirectory' = $workingDirectory |
There was a problem hiding this comment.
input_workingDirectory
ericsciple
force-pushed
the
users/ersciple/m120script
branch
2 times, most recently
from
2b7b07d to
10703df
Compare
|
note to self, finished testing win impl |
ericsciple
force-pushed
the
users/ersciple/m120script
branch
from
10703df to
376d0ad
Compare
ericsciple
force-pushed
the
users/ersciple/m120script
branch
from
376d0ad to
8c16fea
Compare
|
Heya, This significantly reduces its usefulness when used in task groups that can automatically discover configurable inputs from arguments used in a script.
vs File Path:
Reported issue at #4971 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.