Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users/pspill/no cred config on prem #4557

Merged
merged 4 commits into from
Jun 15, 2017
Merged

Users/pspill/no cred config on prem #4557

merged 4 commits into from
Jun 15, 2017

Conversation

pspill
Copy link

@pspill pspill commented Jun 15, 2017

In "dotnet nuget push", we should detect if we are pushing to an internal on prem server. If yes, skip credential configuration -- integrated auth must be used.

@pspill pspill requested a review from emanuelquintero June 15, 2017 22:51
aldoms
aldoms approved these changes Jun 15, 2017
View reviewed changes
Copy link
Contributor

@aldoms aldoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we should rev the versions on the task.json and package.json

@pspill pspill merged commit 01daffe into microsoft:master Jun 15, 2017
@thesattiraju
Copy link
Contributor

@pspill squash and merge from next time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldoms aldoms aldoms approved these changes

@emanuelquintero emanuelquintero Awaiting requested review from emanuelquintero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pspill @thesattiraju @aldoms @msftclas