Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing bug where JenkinsQueueJob task waits #4532

Merged
merged 1 commit into from
Jun 13, 2017
Merged

Fixing bug where JenkinsQueueJob task waits #4532

merged 1 commit into from
Jun 13, 2017

Conversation

jpricket
Copy link
Member

even when the capture console checkbox is not checked
Bug #1017420

@jpricket
Fixing bug where JenkinsQueueJob task waits
c43897e 
even when the capture console checkbox is not checked
Bug #1017420
@jpricket jpricket requested a review from davidstaheli June 13, 2017 18:25
@jpricket
Copy link
Member Author

This is my proposed fix. I could not find any recent changes that were likely to introduce this bug.

@jpricket
Copy link
Member Author

Testing:

  • ran unit tests
  • Ran against various Canary jenkins jobs (like BuildCanary_Pipeline_Root)
    • with capture true and pipline true
    • with capture true and pipline false
    • with capture false and pipline false (false/true is not allowed)
      All results were as expected.

@jpricket jpricket merged commit 030c1b9 into master Jun 13, 2017
@jpricket jpricket deleted the users/jpricket/jenkins branch June 13, 2017 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidstaheli davidstaheli davidstaheli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpricket @davidstaheli @msftclas