Users/pspill/dotnet2 #4520
Users/pspill/dotnet2 #4520
Conversation
Tasks/DotNetCoreCLI/package.json
Outdated
| "q": "^1.4.1", | ||
| "archiver": "1.2.0" | ||
| "archiver": "1.2.0", |
There was a problem hiding this comment.
Check if we need OSS registration for this version of archiver.
There was a problem hiding this comment.
downgraded to approved archiver 1.0.1
Tasks/DotNetCoreCLI/packcommand.ts
Outdated
|
|
||
| const dotnetPath = tl.which("dotnet", true); | ||
| for (const file of filesList) { | ||
| await dotnetPackAsync(dotnetPath, file, outputDir, nobuild, version, props, verbosity); |
There was a problem hiding this comment.
Could/should we do this on parallel?
There was a problem hiding this comment.
good idea, but I'm worried interleaved output on async tool.exec would be confusing on error,
Tasks/DotNetCoreCLI/packcommand.ts
Outdated
| } | ||
| } | ||
|
|
||
| function dotnetPackAsync(dotnetPath: string, packageFile: string, outputDir: string, nobuild: boolean, version: string, properties: string[], verbosity: string) { |
There was a problem hiding this comment.
nit: add function return type
|
|
||
| for (const packageFile of filesList) { | ||
|
|
||
| await dotNetNuGetPushAsync(dotnetPath, packageFile, feedUri, apiKey, configFile, tempNuGetConfigDirectory); |
There was a problem hiding this comment.
same here, would we benefit from parallel push?
| import * as commandHelper from "nuget-task-common/CommandHelper"; | ||
|
|
||
|
|
||
| const NUGET_ORG_V3_URL: string = "https://api.nuget.org/v3/index.json"; |
There was a problem hiding this comment.
Nit. This should be in a common location.
| tl.debug(`All URL prefixes: ${urlPrefixes}`); | ||
| } | ||
|
|
||
| let accessToken = auth.getSystemAccessToken(); |
There was a problem hiding this comment.
Should all of the config code placed in a common location since it's the same as nugetRestore?
There was a problem hiding this comment.
It's not exactly the same, so factoring out common areas cleanly would take some work.
Tasks/DotNetCoreCLI/task.json
Outdated
| }, | ||
| "minimumAgentVersion": "2.0.0", | ||
| "instanceNameFormat": "dotnet $(command)", | ||
| "groups": [], | ||
| "groups": [ |
This PR contains the following changes for the DotNetCoreCLI build task:
UI and experience is consistent with NuGetCommand build task for restore/pack/push