Correct option value for tar.gz compression #4507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpricket
reviewed
Jun 9, 2017
| @@ -70,7 +70,7 @@ | |||
| "groupName": "archive", | |||
| "visibleRule": "archiveType = tar", | |||
| "options": { | |||
| "default": "gz", | |||
There was a problem hiding this comment.
Is there any harm in removing "default" from the list? (I assume not, but may be worth testing how an existing definition with the value default works with this change).
There was a problem hiding this comment.
Good question. I confirmed that this change only affects the UI: the drop-down displays an initial value instead of being blank. But the behavior doesn't change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4497. I tested it on the build canary and by running legacy tests.