Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom map support #4467

Merged
merged 10 commits into from
Jun 14, 2017
Merged

custom map support #4467

merged 10 commits into from
Jun 14, 2017

Conversation

acesiddhu
Copy link
Contributor

No description provided.

@acesiddhu acesiddhu requested a review from cltshivash June 9, 2017 10:35
@@ -304,7 +306,8 @@ function generateResponseFile(discoveredTests: string): Q.Promise<string> {
'context': tiaConfig.context,
'platform': platformInput,
'configuration': configurationInput,
'useTestCaseFilterInResponseFile': useTestCaseFilterInResponseFile
'useTestCaseFilterInResponseFile': useTestCaseFilterInResponseFile,
'TestCaseFilterOutputFile' : testCaseFilterOutputFile ? testCaseFilterOutputFile : ""
Copy link
Contributor

@cltshivash cltshivash Jun 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestCaseFilterOutputFile [](start = 13, length = 24)

minor: casing #Resolved

@@ -392,7 +395,9 @@ function publishCodeChanges(): Q.Promise<string> {
'rebaselimit': rebaseLimit,
'baselinefile': tiaConfig.baseLineBuildIdFile,
'context': tiaConfig.context,
'filter': pathFilters
'filter': pathFilters,
'UserMapFile': tiaConfig.userMapFile ? tiaConfig.userMapFile : "",
Copy link
Contributor

@cltshivash cltshivash Jun 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UserMapFile [](start = 13, length = 11)

minor: casing #Resolved

'filter': pathFilters
'filter': pathFilters,
'UserMapFile': tiaConfig.userMapFile ? tiaConfig.userMapFile : "",
'testCaseFilterResponseFile': testCaseFilterFile ? testCaseFilterFile : ""
Copy link
Contributor

@cltshivash cltshivash Jun 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testCaseFilterResponseFile [](start = 13, length = 26)

256 chars limit..? #Closed

@cltshivash
Copy link
Contributor

:shipit:

@acesiddhu acesiddhu merged commit dbbe8fd into master Jun 14, 2017
@bryanmacfarlane bryanmacfarlane deleted the users/siddhap/customscript branch January 31, 2018 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants