Fixed issues when writing response file that is passed to vstest.console.exe #4383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RanjanarMS
approved these changes
May 23, 2017
Tasks/VsTest/helpers.ts
Outdated
| return '\"' + argument + '\"'; | ||
| } else { | ||
| // we need to add quotes to args we are passing after : as the arg value can have spaces | ||
| // we dont need to chnages the guy who is creating the args as toolrunner already takes care of this |
There was a problem hiding this comment.
nitpick : spellcheck #Resolved
Tasks/VsTest/helpers.ts
Outdated
| }); | ||
| } | ||
|
|
||
| public static modifyArgument(argument: string): string { |
There was a problem hiding this comment.
rename modifyVstestConsoleArg since it is specific to vstest.console.exe #Closed
There was a problem hiding this comment.
well it is not the args specified to vstest console directly but via reponse file. will rename to something like modifyVsTestConsoleArgsForResponseFile
In reply to: 117964774 [](ancestors = 117964774)
Tasks/VsTest/helpers.ts
Outdated
| // for response file we need to take care of this ourselves | ||
| // eg: /settings:c:\a b\1.settings should become /settings:"C:\a b\1.settings" | ||
| let indexOfColon = argument.indexOf(':'); // find if args has ':' | ||
| if (indexOfColon > 0 && argument[indexOfColon + 1] !== '\"') { // only process when quotes are not there |
There was a problem hiding this comment.
What happens if it already within quotes? #Closed
There was a problem hiding this comment.
it wont add quotes again. check the condition. added a test case for the same
In reply to: 117965015 [](ancestors = 117965015)
added 2 commits
May 23, 2017 17:01
prawalagarwal
approved these changes
May 24, 2017
added 2 commits
May 24, 2017 12:30
cltshivash
approved these changes
May 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: if setting file had a space things were not working.