Fix for ..\directory type entries for search folder #4373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RanjanarMS
approved these changes
May 23, 2017
Tasks/VsTest/taskinputparser.ts
Outdated
| @@ -7,6 +7,7 @@ import * as utils from './helpers'; | |||
| import * as os from 'os'; | |||
| import * as versionFinder from './versionfinder'; | |||
| const uuid = require('node-uuid'); | |||
| import {isNullOrWhitespace} from './vstest' | |||
Tasks/VsTest/taskinputparser.ts
Outdated
| @@ -97,12 +98,20 @@ function initTestConfigurations(testConfiguration: models.TestConfigurations) { | |||
| tl._writeLine(tl.loc('testSelectorInput', testConfiguration.testSelection)); | |||
|
|
|||
| testConfiguration.testDropLocation = tl.getInput('searchFolder'); | |||
| if (!isNullOrWhitespace(testConfiguration.testDropLocation)) | |||
There was a problem hiding this comment.
Are we assigning some default if it is empty? Or is there any validation for this?
There was a problem hiding this comment.
We don't want to change if it is null or empty. These cases are handled when they are actually used.
Tasks/VsTest/vstest.ts
Outdated
| } | ||
|
|
||
| export {isNullOrWhitespace}; |
There was a problem hiding this comment.
Move to helper class as mentioned above
| tr.setInput('testAssemblyVer2', '/source/dir/someFile1'); | ||
| tr.setInput('vstestLocationMethod', 'version'); | ||
| tr.setInput('vsTestVersion', '14.0'); | ||
| tr.setInput('pathtoCustomTestAdapters', 'E:/path/to/../customadapters'); |
There was a problem hiding this comment.
Can you add one test case for netwok path in all the scenarios?
There was a problem hiding this comment.
Will discuss in scrum
cltshivash
approved these changes
May 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The root directory path for searching test assemblies does not support ..\directory type entries.
Fix: This fix resolves this issue.
Testing: Unit and Manual