Users/lukillgo/installsshkey #4258
Conversation
Tasks/InstallSSHKey/task.json
Outdated
| "id": "5c9af2eb-5fc5-42dc-9b91-dc234a8c4400", | ||
| "name": "InstallSSHKey", | ||
| "friendlyName": "Install SSH Key (Preview)", | ||
| "description": "Install an SSH key prior to a build", |
There was a problem hiding this comment.
Install an SSH key prior to a build or release
Tasks/InstallSSHKey/task.json
Outdated
| { | ||
| "name": "hostName", | ||
| "type": "string", | ||
| "label": "Known hosts entry", |
There was a problem hiding this comment.
Capitalize all words in the label for consistency with other fields.
Tasks/InstallSSHKey/task.json
Outdated
| "label": "SSH Key", | ||
| "defaultValue": "", | ||
| "required": true, | ||
| "helpMarkDown": "Select the SSH key that was uploaded to `Secure Files` to install on the build agent." |
There was a problem hiding this comment.
"build agent" can just be "agent" so that it applies to releases too.
Tasks/InstallSSHKey/task.json
Outdated
| } | ||
| }, | ||
| "messages": { | ||
| "SSHKeyAlreadyInstalled": "The SSH Key is already installed.", |
There was a problem hiding this comment.
"Key" shouldn't be capitalized here.
| let deleteKey: string = tl.getTaskVariable(postDeleteKeySetting); | ||
| if (deleteKey) { | ||
| tl.debug('Deleting Key: ' + deleteKey); | ||
| tl.execSync(path.join(external, 'ssh-add.exe'), '-d ' + deleteKey); |
There was a problem hiding this comment.
There is a risk of this not working when there are spaces in the deleteKey path. If you use a ToolRunner from the task library and add each item as a formal parameter ('-d', deleteKey), I think it will take care of putting quotes around the path for you if it has spaces.
| if (knownHostsContents && knownHostsLocation) { | ||
| fs.writeFileSync(knownHostsLocation, knownHostsContents); | ||
| } else if (knownHostsLocation || knownHostsContents) { | ||
| tl.warning('Inconsistency with known_hosts cannot reset (location=' + knownHostsLocation + ' content=' + knownHostsContents + ')'); |
There was a problem hiding this comment.
This warning should be localized and is a little difficult to understand. Or did you mean for it to be debug output?
There was a problem hiding this comment.
I probably should let them know that the known_hosts file has been changed and cannot be changed back. I'll re-work this.
| } catch(err) { | ||
| tl.setResult(tl.TaskResult.Failed, err); | ||
| } finally { | ||
| // delete provisioning profile from temp location after installing |
There was a problem hiding this comment.
P999: This left-over comment refers to "provisioning profiles"
|
|
||
| import util = require('./installsshkey-util'); | ||
|
|
||
| // var sshAgent = require('ssh-agent-js'); |
There was a problem hiding this comment.
Can this commented line be removed?
New task: Install SSH Key