Show http request code to avoid random failures with empty error #4237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhurig
commented
May 4, 2017
| @@ -171,34 +177,34 @@ function publishRelease(apiServer: string, releaseUrl: string, releaseNotes: str | |||
| * If the input is a single folder, zip it's content. The archive name is the folder's name | |||
| * If the input is a set of folders or files, zip them so they appear on the root of the archive. The archive name is the parent folder's name. | |||
| */ | |||
| function prepareSymbols(symbolsPaths: string[]): Q.Promise<string> { | |||
| function prepareSymbols(symbolsPaths: string[]): Q.Promise<string> { | |||
There was a problem hiding this comment.
Formatting changes (Shift + Option + F) in VSCode on macOS.
AlexRukhlin
reviewed
May 5, 2017
| message = `http response code: ${res.statusCode}`; | ||
| } else { | ||
| message = message.concat(os.EOL + `http response code: ${res.statusCode}`); | ||
| } | ||
| defer.reject(message); |
There was a problem hiding this comment.
I'd also use ${JSON.stringify(err)} instead of just ${err} at the end of the file. Also, tl.error(...) call won't hurt before tl.setResult(...)
There was a problem hiding this comment.
Both suggestions while they don't hurt are not required. Based on my experiments with node REPL, I am fairly confident about the fix I made being sufficient :). At least we will always get the http response code every time.
davidstaheli
approved these changes
May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.