Users/ersciple/m117fallback #4170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Collecting early feedback. I still need to do the following:
|
ericsciple
commented
Apr 27, 2017
| Write-Verbose $_ | ||
| $null = $output.AppendLine($_) | ||
| } | ||
| if (!$script:visualStudioCache.ContainsKey('15.0')) { |
There was a problem hiding this comment.
i added a cache since VSBuild potentially calls twice. Once to resolve VS, and then again to resolve MSBuild location.
ericsciple
commented
Apr 27, 2017
| } finally { | ||
| Trace-VstsLeavingInvocation $MyInvocation | ||
| } | ||
| } | ||
|
|
||
| function Select-MSBuildPath { |
There was a problem hiding this comment.
xamarin android and msbuild tasks both use this same logic, so i moved it into the common module
madhurig
reviewed
Apr 27, 2017
TingluoHuang
approved these changes
Apr 27, 2017
ericsciple
force-pushed
the
users/ersciple/m117fallback
branch
from
5765f31 to
fdc1d0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.