Azure App service Manage & Deploy Task Spec changes #4125

vincent1173 · 2017-04-25T18:23:13Z

No description provided.

dikhakha · 2017-04-26T18:16:53Z

Tasks/AzureAppServiceManage/azureappservicemanage.ts

+        tl.debug('App Service State : ' + appServiceDetails.properties.state);
+        while(!(appServiceDetails.properties.state == "Running" || appServiceDetails.properties.state == "running"))
+        {
+            appServiceDetails = await azureRmUtil.getAppServiceDetails(endPoint, resourceGroupName, webAppName, specifySlotFlag, slotName);


do you want to add a wait() here and retry after certain intervals?

wait is actually not required as we just poll for the state of the app and not on any operation.

We should check for hasProperty("properties") and hasProperty("state") after getting appServiceDetails in while loop

kmkumaran · 2017-04-27T03:32:41Z

Tasks/AzureAppServiceManage/azureappservicemanage.ts

-                        appServiceDetails = await azureRmUtil.getAppServiceDetails(endPoint, resourceGroupName, webAppName, specifySlotFlag, slotName);
-                    }
-                }
+                await waitForAppServiceToStart(endPoint, resourceGroupName, webAppName, specifySlotFlag, slotName);
                break;
            }
            case "Stop Azure App Service": {


Should we wait for Stop as well?

Stop actually stops the App Service to accept any request. We should be good here.

kmkumaran · 2017-04-27T03:38:06Z

Tasks/AzureRmWebAppDeployment/kuduutility.ts

@@ -403,7 +403,7 @@ async function getPostDeploymentScriptLogs(publishingProfile, physicalPath, uniq
        console.log(tl.loc('stderrFromScript'));
        if(scriptReturnCode != '0') {
            tl.error(stderrLog);
-            throw Error(tl.loc('ScriptExecutionOnKuduFailed', scriptReturnCode, stderrLog));


Why this change?

kmkumaran · 2017-04-27T03:50:01Z

Tasks/AzureRmWebAppDeployment/task.json

@@ -475,6 +475,7 @@
        "ScriptStatusTimeout": "Unable to fetch script status due to timeout.",
        "PollingForFileTimeOut": "Unable to fetch script status due to timeout. You can increase the timeout limit by setting 'appservicedeploy.retrytimeout' variable to number of minutes required.",
        "InvalidPollOption": "Invalid polling option provided: %s.",
-        "MissingWebConfigParameters": "Some web.config parameters are missing"
+        "MissingWebConfigParameters": "Some web.config parameters are missing",


Is there a guidance we can provide? Either a link where defaults are available... or guidance on how and where to edit.

Help Text need to be updated at many places. Will update once I get the message reviewed by @azooinmyluggage

kmkumaran · 2017-04-27T03:51:27Z

Tasks/Common/webdeployment-common/generatewebconfig.ts

@@ -17,3 +17,53 @@ function replaceMultiple(text: string, substitutions: any): string {
    }
    return text;
 }
+


The file name as generatewebconfig is not appropriate any more. Should this be webconfigutils?

Also reconcile between generateWebConfigFile and addWebConfigFile

kmkumaran · 2017-04-27T08:14:20Z

Tasks/AzureRmWebAppDeployment/postDeploymentScript/mainCmdFile.cmd

+
+cmd /c "kuduPostDeploymentScript_%1.cmd" > "stdout_%1.txt" 2> "stderr_%1.txt" && (


Try the changes that we discussed.

kmkumaran · 2017-04-30T15:42:23Z

Tasks/AzureRmWebAppDeployment/Strings/resources.resjson/en-US/resources.resjson

@@ -140,7 +140,7 @@
  "loc.messages.ScriptStatusTimeout": "Unable to fetch script status due to timeout.",
  "loc.messages.PollingForFileTimeOut": "Unable to fetch script status due to timeout. You can increase the timeout limit by setting 'appservicedeploy.retrytimeout' variable to number of minutes required.",
  "loc.messages.InvalidPollOption": "Invalid polling option provided: %s.",
-  "loc.messages.MissingWebConfigParameters": "Some web.config parameters are missing",
+  "loc.messages.MissingAppTypeWebConfigParameters": "-appType attribute is missing in Web.config parameters.",


Is apptype the only config param that can be missing? Should we also report if other required parameters are not present?

We can override with default values. I ll update it in this PR.

RoopeshNair · 2017-05-03T10:43:54Z

Tasks/AzureAppServiceManage/Strings/resources.resjson/en-US/resources.resjson

@@ -23,6 +23,8 @@
  "loc.input.label.Slot": "Slot",
  "loc.input.label.ExtensionsList": "Install Extensions",
  "loc.input.help.ExtensionsList": "Site Extensions run on Microsoft Azure App Service. You can install set of tools as site extension and better manage your Azure App Service. The  App Service will be restarted to make sure latest changes take effect.",
+  "loc.input.label.OutputVariable": "Output variable",
+  "loc.input.help.OutputVariable": "Provide comma separated list of variables that saves the local path of the extension which can be used in subsequent tasks.",


"Provide the variable name for the local installation path for the selected extension.

Note: In case of multiple extensions selected for installation, provide comma separated list of variables that saves the local path for each of the selected extension in the order it appears in the Install Extension field"

RoopeshNair · 2017-05-03T10:50:32Z

Tasks/AzureRmWebAppDeployment/task.json

@@ -475,6 +475,10 @@
        "ScriptStatusTimeout": "Unable to fetch script status due to timeout.",
        "PollingForFileTimeOut": "Unable to fetch script status due to timeout. You can increase the timeout limit by setting 'appservicedeploy.retrytimeout' variable to number of minutes required.",
        "InvalidPollOption": "Invalid polling option provided: %s.",
-        "MissingWebConfigParameters": "Some web.config parameters are missing"
+        "MissingAppTypeWebConfigParameters": "-appType attribute is missing in Web.config parameters.",


Attribute '-appType' is missing in the Web.config parameters. Valid values for '-appType' are: 'python_Bottle', 'python_Django', 'python_Flask' and 'node'.

For example, '-appType python_Bottle' (sans-quotes) in case of Python Bottle framework.

RoopeshNair · 2017-05-03T10:53:52Z

Tasks/AzureRmWebAppDeployment/task.json

@@ -475,6 +475,10 @@
        "ScriptStatusTimeout": "Unable to fetch script status due to timeout.",
        "PollingForFileTimeOut": "Unable to fetch script status due to timeout. You can increase the timeout limit by setting 'appservicedeploy.retrytimeout' variable to number of minutes required.",
        "InvalidPollOption": "Invalid polling option provided: %s.",
-        "MissingWebConfigParameters": "Some web.config parameters are missing"
+        "MissingAppTypeWebConfigParameters": "-appType attribute is missing in Web.config parameters.",
+        "AutoDetectDjangoSettingsFailed": "Unable to detect DJANGO_SETTINGS_MODULE (settings.py). Please ensure that the file exists or provide the correct path in Web.config parameters input in the following format '<folder_name>.settings'",


"Unable to detect DJANGO_SETTINGS_MODULE 'settings.py' file path. Ensure that the 'settings.py' file exists or provide the correct path in Web.config parameter input in the following format '-DJANGO_SETTINGS_MODULE <folder_name>.settings'",

RoopeshNair · 2017-05-03T11:03:27Z

Tasks/AzureRmWebAppDeployment/task.json

-        "MissingWebConfigParameters": "Some web.config parameters are missing"
+        "MissingAppTypeWebConfigParameters": "-appType attribute is missing in Web.config parameters.",
+        "AutoDetectDjangoSettingsFailed": "Unable to detect DJANGO_SETTINGS_MODULE (settings.py). Please ensure that the file exists or provide the correct path in Web.config parameters input in the following format '<folder_name>.settings'",
+        "FailedToApplyTransformation": "Unable to apply transformation for the given package. Please follow below steps to debug the issue. \n1. Transformation is applied for MSBuild generated packge during build time. Remove <DependentUpon> Tag for each config file. \n2. Ensure that the config file and transformation file are present in the same folder inside the package.",


"Unable to apply transformation for the given package. Verify the following. \n1. Whether the Transformation is already applied for the MSBuild generated package during build. If yes, remove the tag for each config in the csproj file and rebuild. \n2. Ensure that the config file and transformation files are present in the same folder inside the package.",

RoopeshNair · 2017-05-03T11:15:33Z

Tasks/AzureRmWebAppDeployment/task.json

+        "MissingAppTypeWebConfigParameters": "-appType attribute is missing in Web.config parameters.",
+        "AutoDetectDjangoSettingsFailed": "Unable to detect DJANGO_SETTINGS_MODULE (settings.py). Please ensure that the file exists or provide the correct path in Web.config parameters input in the following format '<folder_name>.settings'",
+        "FailedToApplyTransformation": "Unable to apply transformation for the given package. Please follow below steps to debug the issue. \n1. Transformation is applied for MSBuild generated packge during build time. Remove <DependentUpon> Tag for each config file. \n2. Ensure that the config file and transformation file are present in the same folder inside the package.",
+        "AutoParameterizationMessage": "ConnectionString attributes in Web.config is parameterized by default. Please be aware that transformation has no effect on connectioString attributes as the same value is overridden during deployment. You can disable the auto parameterization by setting /p:AutoParameterizationWebConfigConnectionStrings=False during MSBuild package generation.",


ConnectionString attributes in Web.config is parameterized by default. Note that the transformation has no effect on connectionString attributes as the value is overridden during deployment by 'Parameters.xml or SetParameters" files. You can disable the auto-parameterization by setting /p:AutoParameterizationWebConfigConnectionStrings=False during MSBuild package generation."

kmkumaran · 2017-05-03T16:57:32Z

Tasks/AzureAppServiceManage/task.json

+            "label": "Output variable",
+            "defaultValue": "",
+            "visibleRule": "Action = Install Extensions",
+            "helpMarkDown": "Provide the variable name for the local installation path for the selected extension.<br />Note: In case of multiple extensions selected for installation, provide comma separated list of variables that saves the local path for each of the selected extension in the order it appears in the Install Extension field"


Give an example. Should the name be just varName or $(varName)?

kmkumaran · 2017-05-03T17:05:08Z

Tasks/Common/webdeployment-common/ltxdomutility.ts

@@ -82,7 +82,7 @@ export function getChildElementsByTagName(node, tagName) {
            }
            var liveChildNodes = getChildElementsByTagName(children[i], tagName);
            if(liveChildNodes && liveChildNodes.length > 0){
-            	liveNodes.concat(liveChildNodes);
+            	liveNodes = liveNodes.concat(liveChildNodes);


Why this change?

kmkumaran · 2017-05-03T17:11:55Z

Tasks/Common/webdeployment-common/fileTransformationsUtility.ts

+        if(!isFolderBasedDeployment && utility.isMSDeployPackage(webDeployPkg)) {
+            var debugMode = tl.getVariable('system.debug');
+            if(debugMode && debugMode.toLowerCase() == 'true') {
+                tl.warning(tl.loc('AutoParameterizationMessage'));


Where is this message from? I can't see in task.json.

Message is available in AzureRmWebAppDeployment/task.json

kmkumaran · 2017-05-03T17:13:14Z

Tasks/Common/webdeployment-common/fileTransformationsUtility.ts

@@ -7,9 +7,18 @@ var jsonSubstitutionUtility = require('webdeployment-common/jsonvariablesubstitu
 var xmlSubstitutionUtility = require('webdeployment-common/xmlvariablesubstitutionutility.js');
 var xdtTransformationUtility = require('webdeployment-common/xdttransformationutility.js');

-export function fileTransformations(isFolderBasedDeployment: boolean, JSONFiles: any, xmlTransformation: boolean, xmlVariableSubstitution: boolean, folderPath: string) {
+export function fileTransformations(isFolderBasedDeployment: boolean, JSONFiles: any, xmlTransformation: boolean, xmlVariableSubstitution: boolean, folderPath: string, webDeployPkg: string) {


why do you need webDeployPkg itself instead of passing a Boolean of isMSDeployPackage?

… users/vinca/changeDeploymentScriptLogic

dikhakha · 2017-05-04T10:51:53Z

Tasks/AzureAppServiceManage/extensionmanage.ts

+    if(extensionId.startsWith('python2')) {
+        return homeDir + "Python27";
+    }
+    else if(extensionId.startsWith('python351') || extensionId.startsWith('python352')) {


this may not be required as we are not showing option to install 3.5 < python version < 3.5.3 ?

Additional check, if we add them.

Post deployment script logic changed

0cf2859

msftclas added the cla-not-required label Apr 25, 2017

vincent1173 requested review from kmkumaran, mvvsubbu and dikhakha April 26, 2017 05:37

added await for waitForAppServiceToStart()

3f4a15f

dikhakha reviewed Apr 26, 2017

View reviewed changes

kmkumaran reviewed Apr 27, 2017

View reviewed changes

Fix - 2

6a8d626

vincent1173 mentioned this pull request Apr 28, 2017

Azure App Service Deploy XML Transformation ctt.exe Not Taking Effect #4160

Closed

vincent1173 added 2 commits April 28, 2017 18:51

addressed review comments

360cca0

help text updated

8c5c02a

kmkumaran reviewed Apr 30, 2017

View reviewed changes

added o/p var. option

9e87356

vincent1173 requested a review from Ajay-MS May 2, 2017 06:11

vincent1173 added 5 commits May 2, 2017 14:40

web.config override undefined with default value

943e6a8

IIS web app deploy task updated

a4479fa

virtual application fix

9f35e22

modified web.config

6415853

update result variable

1340920

RoopeshNair reviewed May 3, 2017

View reviewed changes

help string updated

1f1e813

kmkumaran reviewed May 3, 2017

View reviewed changes

vincent1173 added 3 commits May 4, 2017 10:59

Merge branch 'master' of https://github.com/Microsoft/vsts-tasks into…

0bbfb17

… users/vinca/changeDeploymentScriptLogic

patch version updated

73df314

Addressed Review comments

86c9bf5

vincent1173 added 3 commits May 4, 2017 12:24

IIS App Deploy help string updated

3500570

bugbash fix

4f16b46

Bug Bash Fix 2

9ab7ef1

dikhakha reviewed May 4, 2017

View reviewed changes

kmkumaran approved these changes May 4, 2017

View reviewed changes

vincent1173 merged commit e668633 into master May 4, 2017

bryanmacfarlane deleted the users/vinca/changeDeploymentScriptLogic branch January 31, 2018 00:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Azure App service Manage & Deploy Task Spec changes #4125

Azure App service Manage & Deploy Task Spec changes #4125

vincent1173 commented Apr 25, 2017

dikhakha Apr 26, 2017

vincent1173 Apr 30, 2017

Ajay-MS May 2, 2017

kmkumaran Apr 27, 2017

vincent1173 Apr 28, 2017 •

edited

Loading

kmkumaran Apr 27, 2017

kmkumaran Apr 27, 2017

vincent1173 Apr 28, 2017

kmkumaran Apr 27, 2017

kmkumaran Apr 27, 2017

kmkumaran Apr 27, 2017

kmkumaran Apr 30, 2017

vincent1173 Apr 30, 2017 •

edited

Loading

RoopeshNair May 3, 2017

RoopeshNair May 3, 2017

RoopeshNair May 3, 2017 •

edited

Loading

RoopeshNair May 3, 2017

RoopeshNair May 3, 2017

kmkumaran May 3, 2017

kmkumaran May 3, 2017

kmkumaran May 3, 2017

vincent1173 May 4, 2017

kmkumaran May 3, 2017

dikhakha May 4, 2017

vincent1173 May 4, 2017


		cmd /c "kuduPostDeploymentScript_%1.cmd" > "stdout_%1.txt" 2> "stderr_%1.txt" && (

Azure App service Manage & Deploy Task Spec changes #4125

Azure App service Manage & Deploy Task Spec changes #4125

Conversation

vincent1173 commented Apr 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vincent1173 Apr 28, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vincent1173 Apr 30, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RoopeshNair May 3, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vincent1173 Apr 28, 2017 •

edited

Loading

vincent1173 Apr 30, 2017 •

edited

Loading

RoopeshNair May 3, 2017 •

edited

Loading