enabled automatic detection of PR flow and made /test default. this can be overriden by using TIA.useTestCaseFilterInResponseFile #4124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
acesiddhu
commented
Apr 25, 2017
•
acesiddhu
commented
- using Build.Reason to detect if the build is a PR build. This variables was added recently
- made /test: default. This behavior can be overridden by specifying a variable. xunit (.9)does not honour /FullyQualifiedName by default.
…an be overriden by using TIA.useTestCaseFilterInResponseFile
added 4 commits
April 25, 2017 22:08
…siddhap/tiafixesforprflow
…siddhap/tiafixesforprflow
| tiaConfiguration.isPrFlow = "true"; | ||
| } | ||
| else { | ||
| tiaConfiguration.isPrFlow = tl.getVariable('tia.isPrFlow'); |
There was a problem hiding this comment.
If tia.isPrFlow is not defined in the task as variable, what is the default value which gets assigned here? Are we handling it in test selector?
prawalagarwal
approved these changes
May 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.