Users/omeshp/package task changes #4081
Conversation
|
@omeshp, |
Tasks/DownloadPackage/download.ts
Outdated
| @@ -8,6 +8,7 @@ import * as restm from 'vso-node-api/RestClient'; | |||
| import * as tl from 'vsts-task-lib/task'; | |||
| import * as vsom from 'vso-node-api/VsoClient'; | |||
| import * as vsts from "vso-node-api/WebApi" | |||
| import bearm = require('vso-node-api//handlers/bearertoken'); | |||
Tasks/DownloadPackage/package.json
Outdated
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "packagedownloader", | |||
| "name": "downloadpackage", | |||
| "version": "1.0.0", | |||
| "description": "Package Downloader Task", | |||
There was a problem hiding this comment.
Download Package Task
Tasks/DownloadPackage/task.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "id": "8d6e8f7e-267d-442d-8c92-1f586864c62f", | |||
| "name": "PackageDownloader", | |||
| "name": "DownloadPackage", | |||
| "friendlyName": "Package Downloader", | |||
There was a problem hiding this comment.
none of the other tasks have spaces in name.
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "packagedownloader", | |||
| "name": "downloadpackage", | |||
There was a problem hiding this comment.
can we add the package name to the instance name so that it appears as:
Download Package {Package name} in logs?
There was a problem hiding this comment.
It will show Package Id, we currently don't have support to show display value of picklist in instanceName
|
|
||
| export async function downloadPackage(collectionUrl: string, credentialHandler: bearm.BearerCredentialHandler, feedId: string, packageId: string, version: string, downloadPath: string) { | ||
|
|
||
| var feedsUrl = collectionUrl.replace(".visualstudio.com",".feeds.visualstudio.com"); |
There was a problem hiding this comment.
for dev. fabric this wouldn't work. since we don't have this working in dev. fabric as of now, it seems fine. but we need to figure out how to make this work in dev. fabric as part of adding L2 test for this scenario. let's take up this investigation then.
Tasks/DownloadPackage/task.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "id": "8d6e8f7e-267d-442d-8c92-1f586864c62f", | |||
| "name": "PackageDownloader", | |||
| "name": "DownloadPackage", | |||
| "friendlyName": "Package Downloader", | |||
| "description": "Download a package from a Package Management feed in VSTS or TFS. \r\n Requires the Package Management extension.", | |||
There was a problem hiding this comment.
bump up patch version?
omeshp
force-pushed
the
users/omeshp/PackageTaskChanges
branch
from
b3e19a5 to
dc10614
Compare
Fix options url used for quering.
Rename Task to DownloadPackage.