Updated testsettings and loadtest files folder not to use the source #4041
Conversation
…files control Updated the description for the forward link to remove the dot to prevent it being broken in the new task editor
…st settings non-mandatory
| $global:RunTestSettingsFile = ""; | ||
| Write-Host -NoNewline ("Selected load test file is '{0}' under '{1}'" -f $file.FullName, $global:ScopedTestDrop) | ||
| Write-Host -NoNewline "Test Drop location used for the run is $global:ScopedTestDrop. Please ensure all required files (test dlls, plugin dlls, dependent files) are part of this output folder" | ||
| if ([string]::IsNullOrWhiteSpace($loadRunTestSettingsFile)) |
There was a problem hiding this comment.
if ([string]::IsNullOrWhiteSpace($loadRunTestSettingsFile)) [](start = 2, length = 59)
minor: you dont need to string check just doing if() would suffice. #WontFix
| { | ||
| $testSettings=[System.IO.Path]::Combine($env:SYSTEM_DEFAULTWORKINGDIRECTORY,$testSettings); | ||
| Write-Host -NoNewline "Updated test settings file is $testSettings"; | ||
| } |
There was a problem hiding this comment.
comment#1 -
this doesnt seem to be related/dependent on the outer if block. it can come out and stay along with the test settings section. #WontFix
| if (-Not (Test-Path $loadRunTestSettingsFile)) | ||
| { | ||
| Write-Host -NoNewline "The path for the test settings file $loadRunTestSettingsFile does not exist" | ||
| if (-Not([System.IO.Path]::IsPathRooted($loadRunTestSettingsFile))) |
There was a problem hiding this comment.
if (-Not([System.IO.Path]::IsPathRooted($loadRunTestSettingsFile))) [](start = 3, length = 67)
if comment #1 is resolved, you will not need this. #WontFix
hope you have verified that having null/empty here wont have an issue. Refers to: Tasks/RunLoadTest/CltTasksUtility.ps1:311 in de134d3. [](commit_id = de134d3, deletion_comment = False) |
|
|
Updated testsettings and loadtest files folder not to use the source
Updated the description for the forward link to remove the dot to prevent it being broken in the new task editor