Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users/lukillgo/failemptycc #4034

Merged
merged 6 commits into from
Apr 17, 2017
Merged

Users/lukillgo/failemptycc #4034

merged 6 commits into from
Apr 17, 2017

Conversation

lkillgore
Copy link
Contributor

No description provided.

Copy link
Contributor

@davidstaheli davidstaheli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One P999 comment.

@@ -98,5 +100,6 @@
"loc.messages.codeAnalysisArtifactSummaryTitle": "Code Analysis Results",
"loc.messages.codeAnalysisDisabled": "Code analysis is disabled outside of the build enviroment. Could not find a value for: %s",
"loc.messages.LocateJVMBasedOnVersionAndArch": "Locate JAVA_HOME for Java %s %s",
"loc.messages.FailedToLocateSpecifiedJVM": "Failed to find specified JDK version. Please make sure environment variable '%s' exists and is set to the location of a corresponding JDK."
"loc.messages.FailedToLocateSpecifiedJVM": "Failed to find specified JDK version. Please make sure environment variable '%s' exists and is set to the location of a corresponding JDK.",
"loc.messages.NoCodeCoverage": "No Code Coverage results were found to publish"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P999 suggestion: lowercase "code coverage" and end with a period.

@lkillgore lkillgore merged commit afa72a2 into master Apr 17, 2017
@lkillgore lkillgore deleted the users/lukillgo/failemptycc branch April 17, 2017 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants