Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DotNetCoreCLI task Upgrade #4013

Merged
merged 3 commits into from
Apr 17, 2017
Merged

Conversation

thesattiraju
Copy link
Contributor

No description provided.

Copy link
Member

@sachinma sachinma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify all the tests are passing. Any new test that needs to get added?

@@ -1,240 +0,0 @@
{
"name": "vsts-tasks-dotnetcoreexe",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we remove this file

Copy link
Contributor Author

@thesattiraju thesattiraju Apr 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was overriding the package.json file upon installation

@thesattiraju thesattiraju merged commit 253867d into master Apr 17, 2017
thesattiraju added a commit that referenced this pull request Apr 17, 2017
* DotNetCore Upgrade

* minor fixes

* Adding UTs
thesattiraju added a commit that referenced this pull request Apr 17, 2017
* DotNetCoreCLI task Upgrade (#4013)

* DotNetCore Upgrade

* minor fixes

* Adding UTs

* npm-shrinkwrap and arg to line

* Not changing all versions

* Updated npm-shrink
@bryanmacfarlane bryanmacfarlane deleted the users/desattir/dotnetCore/Upgrade branch January 31, 2018 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants