Added multiple binding support in IIS Manage #3952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asranja
commented
Apr 5, 2017
| @@ -27,55 +27,6 @@ describe('IISWebAppManagementOnMachineGroup Suite', function () { | |||
| }); | |||
|
|
|||
| if (ps) { | |||
|
|
|||
There was a problem hiding this comment.
Moved the tests for the common script to the vsts-rm-extensions repo
kmkumaran
reviewed
May 3, 2017
| $sslCertThumbprint.Value = [Regex]::Replace($sslCertThumbprint.Value, "[^a-fA-F0-9]+" , "") | ||
|
|
||
| $sslCertThumbPrint.Value = [Regex]::Replace($sslCertThumbPrint.Value, "[^a-fA-F0-9]+" , "") | ||
|
|
||
| # Mark the SSL thumbprint value to be a secret value |
There was a problem hiding this comment.
This comment is not relevant for below newly introduced statements. You can move the comment closer to the below code where we set secret variable.
| if(-not [string]::IsNullOrWhiteSpace($binding.sslThumbprint)) { | ||
| # Trim all non-hexadecimal characters from the ssl cetificate thumbprint | ||
| $sslCertThumbPrint = $binding.sslThumbPrint | ||
| $sslCertThumbPrint = Repair-Inputs -sslCertThumbPrint ([ref]$sslCertThumbPrint) -ipAddress $binding.ipAddress -protocol $binding.protocol -port $binding.port |
There was a problem hiding this comment.
except cert thumbprint, other inputs are not really inputs for repairing. The Name of the method and signature is not matching.
| "properties": { | ||
| "resizable": "true", | ||
| "editorExtension": "ms.vss-services-azure.iis-multiple-binding", | ||
| "displayFormat": "{{#bindings}} {{protocol}}:{{ipAddress}}:{{port}}:{{hostname}} \n{{/bindings}}" |
There was a problem hiding this comment.
Is it possible to have same semantics as in inetmgr.
asranja
changed the title
asranja
added a commit
that referenced
this pull request
May 5, 2017
* Added multiple binding support in IIS Manage and updated major version * Updated the task to handle both current and previous inputs * Addressed review comments and minor fixes * bug fixes
asranja
added a commit
that referenced
this pull request
May 5, 2017
* Added multiple binding support in IIS Manage (#3952) * Added multiple binding support in IIS Manage and updated major version * Updated the task to handle both current and previous inputs * Addressed review comments and minor fixes * bug fixes * Picklist fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.