-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resume MI on timeout. #3778
Merged
vithati
merged 9 commits into
microsoft:master
from
vithati:users/vithati/resumeontimeout
Mar 16, 2017
Merged
Resume MI on timeout. #3778
vithati
merged 9 commits into
microsoft:master
from
vithati:users/vithati/resumeontimeout
Mar 16, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vikranth <[email protected]>
This reverts commit 4da1419.
This reverts commit 3412296.
bansalaseem
reviewed
Mar 16, 2017
Tasks/ManualIntervention/task.json
Outdated
"type": "radio", | ||
"label": "On timeout", | ||
"defaultValue": "Reject", | ||
"required": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make it an optional parameter and file a bug on task editor team to show the default value in the UI for optional parameters
bansalaseem
reviewed
Mar 16, 2017
"type": "radio", | ||
"label": "ms-resource:loc.input.label.onTimeout", | ||
"defaultValue": "Reject", | ||
"required": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
bansalaseem
approved these changes
Mar 16, 2017
mvvsubbu
approved these changes
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.