Fix issue in setting the registry for auto logon and resolving the domain user #3760

nigurr · 2017-03-09T11:13:47Z

Fix issue in finding the test user session active. Previously we are checking for Active sessions available which doesn't give right result whether test user has active session or not
Fix issue in resolving the Domain\Username in Local user groups
Fix issue in DTA Process handling if same machine used for v1 and v2

Testing:

Azure UI Testing - Mseng BID - 3691989
DTA v1, v2 2015/2017 UI Testing

vimegh · 2017-03-09T13:41:07Z

Tasks/DeployVisualStudioTestAgent/SetupTestMachineForUITests.ps1

-    $isSessionActive = IsAnySessionActive
-    if (-not ($isSessionActive))
+    Set-DisableScreenSaverReg | Out-Null
+    ConfigurePowerOptions -MachineCredential $MachineUserCredential | Out-Null


ConfigurePowerOptions -MachineCredential $MachineUserCredential [](start = 4, length = 64)

ConfigurePowerOptions -MachineCredential $MachineUserCredential [](start = 4, length = 64)

ConfigurePowerOptions function doesn't have any param to accept. Please check. #Resolved

Fixed. PS didn't complain #Resolved

…main name for local user accounts

vimegh · 2017-03-09T13:45:04Z

Tasks/DeployVisualStudioTestAgent/SetupTestMachineForUITests.ps1

+    }
+}
+
+# Getting rid of old Session check. WTSEnumerateSessions spits out if there are any active sessions are available


are [](start = 100, length = 3)

are [](start = 100, length = 3)

[opt] not needed #Resolved

didn't get this one. comments/stories are good to have ;)
#Resolved

hence I had said optional [opt]

In reply to: 105172459 [](ancestors = 105172459)

vimegh · 2017-03-09T13:48:30Z

Tasks/DeployVisualStudioTestAgent/SetupTestMachineForUITests.ps1

+{
+    $computer = $env:COMPUTERNAME
+    try {
+        $quserOut = quser.exe /SERVER:$computer 2>&1


quser [](start = 20, length = 5)

Please check windows 7 supports it or not.
as https://technet.microsoft.com/en-us/library/cc754583(v=ws.11).aspx says
Applies To: Windows Vista, Windows Server 2008, Windows Server 2008 R2, Windows Server 2012, Windows 8 #WontFix

We don't support Windows 7 in v2 #Resolved

vimegh · 2017-03-09T13:50:59Z

Tasks/DeployVisualStudioTestAgent/SetupTestMachineForUITests.ps1

+# For UI testing, we need active local users logged in instead of sessions check
+function IsTestUserCurrentlyLoggedIn($TestUserName)
+{
+    $computer = $env:COMPUTERNAME


$computer [](start = 4, length = 9)

This is being used only once. Do we really need it. You can directly pass $env:COMPUTERNAME to quser #WontFix

vimegh · 2017-03-09T13:52:54Z

Tasks/DeployVisualStudioTestAgent/SetupTestMachineForUITests.ps1

-    Remove-ItemProperty -Path 'REGISTRY::HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Winlogon' -Name AutoLogonCount -ErrorAction SilentlyContinue
-    Remove-ItemProperty -Path 'REGISTRY::HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Winlogon' -Name DefaultPassword -ErrorAction SilentlyContinue
-    [MS.VS.TestTools.Config.RegHelper]::SetAutoLogonPassword($TestUserPassword)
+    if ($quserOut -match "No user exists")


$quserOut -match "No user exists" [](start = 8, length = 33)

will this comparison hold in machine with different locales? please check.

vimegh · 2017-03-09T13:57:25Z

Tasks/DeployVisualStudioTestAgent/SetupTestMachineForUITests.ps1

+        return $false
+    }
+
+    $users = $quserOut -replace '\s{2,}', ',' | ConvertFrom-CSV -Header 'username', 'sessionname', 'id', 'state', 'idleTime', 'logonTime'


'username', 'sessionname', 'id', 'state', 'idleTime', 'logonTime' [](start = 72, length = 65)

'username', 'sessionname', 'id', 'state', 'idleTime', 'logonTime' [](start = 72, length = 65)

check for machines with different locales #Resolved

vimegh · 2017-03-09T13:58:54Z

Tasks/DeployVisualStudioTestAgent/SetupTestMachineForUITests.ps1

+    foreach ($user in $users)
+    {
+        Write-Verbose "Logged in user: $($user.username) $($user.state)" -Verbose
+        if(($user.username -ieq $TestUserName) -and ($user.state -ieq 'active')) {


$user.state -ieq 'active' [](start = 53, length = 25)

$user.state -ieq 'active' [](start = 53, length = 25)

please check for different locales #Resolved

vimegh · 2017-03-09T14:03:23Z

Tasks/DeployVisualStudioTestAgent/SetupTestMachineForUITests.ps1

+        Remove-ItemProperty -Path 'REGISTRY::HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Winlogon' -Name DefaultPassword -ErrorAction SilentlyContinue
+
+        [MS.VS.TestTools.Config.RegHelper]::SetAutoLogonPassword($TestUserPassword)
+    }


Add log message - autologon successfully enabled #Resolved

We print that from C# side for success #Resolved

vimegh · 2017-03-09T14:05:44Z

$groupPolicy = (Get-ItemProperty -Path 'REGISTRY::HKEY_CURRENT_USER\Software\Policies\Microsoft\Windows\Control Panel\Desktop' -ErrorAction SilentlyContinue).ScreenSaveActive

Will this point to wow6432node in 64bit machine?

Refers to: Tasks/DeployVisualStudioTestAgent/SetupTestMachineForUITests.ps1:3 in 7bd2674. [](commit_id = 7bd2674, deletion_comment = False)

RanjanarMS

Looks good..

vimegh · 2017-03-10T11:17:31Z

Tasks/DeployVisualStudioTestAgent/SetupTestMachineForUITests.ps1

+                            return true;
+                        }
+                        WTSFreeMemory(userPtr);
+                        WTSFreeMemory(domainPtr);


WTS FreeMemory calls should be place in finally

vimegh · 2017-03-10T11:27:07Z

Tasks/DeployVisualStudioTestAgent/TestAgentHelper.ps1

+        Write-Verbose -Message("Trying to delete service {0}" -f $ServiceName) -Verbose
+        if($service)
+        {
+            $service.StopService()


$service.StopService() [](start = 11, length = 23)

Please check, what happens, if stopping the service throws an error, as we are not handling that?

vimegh · 2017-03-10T11:28:32Z

Tasks/DeployVisualStudioTestAgent/TestAgentHelper.ps1

+        Write-Verbose -Message("Trying to delete service {0}" -f $ServiceName) -Verbose
+        if($service)
+        {
+            $service.StopService()


$service.StopService() [](start = 11, length = 23)

Should we use -Force option here ?

vimegh · 2017-03-10T11:36:25Z

Tasks/DeployVisualStudioTestAgent/TestAgentHelper.ps1

+        {
+            $service.StopService()
+            $deleteServiceCode = $service.Delete()
+            if($deleteServiceCode -eq 0)


f($deleteServiceCode -eq 0) [](start = 13, length = 27)

As per https://msdn.microsoft.com/en-us/library/aa389960(VS.85).aspx Delete method returns 0 if the request was accepted and not for error scenario. Please check.

msftclas added the cla-not-required label Mar 9, 2017

vimegh reviewed Mar 9, 2017

View reviewed changes

Fix issue in setting the registry for auto logon and resolving the do…

cce533c

…main name for local user accounts

nigurr force-pushed the users/nigurr/FixUIIssues branch from c17dc33 to cce533c Compare March 9, 2017 13:43

vimegh reviewed Mar 9, 2017

View reviewed changes

Reverted to WTSEnumerateSessions as quser is locale dependent

7bd2674

RanjanarMS approved these changes Mar 10, 2017

View reviewed changes

vimegh reviewed Mar 10, 2017

View reviewed changes

😊Nitin Gurram😊 added 3 commits March 13, 2017 14:16

Updated signed binaries

38397c2

Adding CRC

be591cb

Merge branch 'master' into users/nigurr/FixUIIssues

cfb04f4

nigurr merged commit 0342e8d into master Mar 13, 2017

nigurr deleted the users/nigurr/FixUIIssues branch April 10, 2017 12:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix issue in setting the registry for auto logon and resolving the domain user #3760

Fix issue in setting the registry for auto logon and resolving the domain user #3760

nigurr commented Mar 9, 2017 •

edited

Loading

vimegh Mar 9, 2017 •

edited by nigurr

Loading

nigurr Mar 9, 2017 •

edited by vimegh

Loading

vimegh Mar 9, 2017 •

edited

Loading

nigurr Mar 9, 2017 •

edited by vimegh

Loading

vimegh Mar 10, 2017

vimegh Mar 9, 2017 •

edited by nigurr

Loading

nigurr Mar 9, 2017 •

edited by vimegh

Loading

vimegh Mar 9, 2017 •

edited by nigurr

Loading

vimegh Mar 9, 2017

vimegh Mar 9, 2017 •

edited

Loading

vimegh Mar 9, 2017 •

edited

Loading

vimegh Mar 9, 2017 •

edited

Loading

nigurr Mar 9, 2017 •

edited by vimegh

Loading

vimegh commented Mar 9, 2017 •

edited

Loading

RanjanarMS left a comment

vimegh Mar 10, 2017

vimegh Mar 10, 2017

vimegh Mar 10, 2017

vimegh Mar 10, 2017 •

edited

Loading

Fix issue in setting the registry for auto logon and resolving the domain user #3760

Fix issue in setting the registry for auto logon and resolving the domain user #3760

Conversation

nigurr commented Mar 9, 2017 • edited Loading

vimegh Mar 9, 2017 • edited by nigurr Loading

Choose a reason for hiding this comment

nigurr Mar 9, 2017 • edited by vimegh Loading

Choose a reason for hiding this comment

vimegh Mar 9, 2017 • edited Loading

Choose a reason for hiding this comment

nigurr Mar 9, 2017 • edited by vimegh Loading

Choose a reason for hiding this comment

vimegh Mar 10, 2017

Choose a reason for hiding this comment

vimegh Mar 9, 2017 • edited by nigurr Loading

Choose a reason for hiding this comment

nigurr Mar 9, 2017 • edited by vimegh Loading

Choose a reason for hiding this comment

vimegh Mar 9, 2017 • edited by nigurr Loading

Choose a reason for hiding this comment

vimegh Mar 9, 2017

Choose a reason for hiding this comment

vimegh Mar 9, 2017 • edited Loading

Choose a reason for hiding this comment

vimegh Mar 9, 2017 • edited Loading

Choose a reason for hiding this comment

vimegh Mar 9, 2017 • edited Loading

Choose a reason for hiding this comment

nigurr Mar 9, 2017 • edited by vimegh Loading

Choose a reason for hiding this comment

vimegh commented Mar 9, 2017 • edited Loading

RanjanarMS left a comment

Choose a reason for hiding this comment

vimegh Mar 10, 2017

Choose a reason for hiding this comment

vimegh Mar 10, 2017

Choose a reason for hiding this comment

vimegh Mar 10, 2017

Choose a reason for hiding this comment

vimegh Mar 10, 2017 • edited Loading

Choose a reason for hiding this comment

nigurr commented Mar 9, 2017 •

edited

Loading

vimegh Mar 9, 2017 •

edited by nigurr

Loading

nigurr Mar 9, 2017 •

edited by vimegh

Loading

vimegh Mar 9, 2017 •

edited

Loading

nigurr Mar 9, 2017 •

edited by vimegh

Loading

vimegh Mar 9, 2017 •

edited by nigurr

Loading

nigurr Mar 9, 2017 •

edited by vimegh

Loading

vimegh Mar 9, 2017 •

edited by nigurr

Loading

vimegh Mar 9, 2017 •

edited

Loading

vimegh Mar 9, 2017 •

edited

Loading

vimegh Mar 9, 2017 •

edited

Loading

nigurr Mar 9, 2017 •

edited by vimegh

Loading

vimegh commented Mar 9, 2017 •

edited

Loading

vimegh Mar 10, 2017 •

edited

Loading