Added special char trimming for ssl and updated help texts #3724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrishnaAdityaB
approved these changes
Mar 3, 2017
| @@ -226,7 +226,11 @@ function Trim-Inputs([ref]$siteName, [ref]$physicalPath, [ref]$poolName, [ref]$v | |||
| } | |||
| if ($sslCertThumbPrint -ne $null) | |||
| { | |||
| $sslCertThumbPrint.Value = $sslCertThumbPrint.Value.Trim() | |||
| # Trim all non-hexadecimal characters from the ssl cetificate thumbprint | |||
| Write-Warning (Get-VstsLocString -Key "SSLCertWarningInvalidCharacters") | |||
There was a problem hiding this comment.
write warning only when there are non-hexadecimal characters
| @@ -627,7 +627,8 @@ | |||
| "InvalidVirtualPath": "Virtual path should begin with a /", | |||
| "InvalidIISDeploymentType": "Invalid IIS Deployment Type : {0}", | |||
| "InvalidActionIISWebsite": "Invalid action '{0}' selected for the IIS Website.", | |||
| "InvalidActionIISAppPool": "Invalid action '{0}' selected for the IIS Application Pool." | |||
| "InvalidActionIISAppPool": "Invalid action '{0}' selected for the IIS Application Pool.", | |||
| "SSLCertWarningInvalidCharacters": "SSL Certificate thumbprint contains non-hexadecimal characters. Trimming all non-hexadecimal characters." | |||
There was a problem hiding this comment.
it will be good to add a forward link to documentation here and help-markdown https://msdn.microsoft.com/en-us/library/windows/desktop/cc307220(v=vs.85).aspx
| Write-Warning (Get-VstsLocString -Key "SSLCertWarningInvalidCharacters") | ||
| $sslCertThumbprint.Value = [Regex]::Replace($sslCertThumbprint.Value, "[^a-fA-F0-9]+" , "") | ||
| $sslCertThumbprintValue = $sslCertThumbprint.Value | ||
| Write-Host "##vso[task.setvariable variable=sslCertThumbprint;isSecret=true]$sslCertThumbprintValue" |
There was a problem hiding this comment.
the variable name may collide. How about using a GUID?
There was a problem hiding this comment.
add a comment to convey the intent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.