Initial changes for packer build task #3702
Conversation
|
@bishalpd, |
| @@ -0,0 +1,86 @@ | |||
| # Azure Resource Group Deployment Task | |||
There was a problem hiding this comment.
This README is of Azure RG task. You should delete/edit this
There was a problem hiding this comment.
This will be modified.
| @@ -0,0 +1,108 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
There was a problem hiding this comment.
You might want to confirm if you are going to use the same icon as ARGDeployment task
There was a problem hiding this comment.
This will be modified.
| "demands": [], | ||
| "minimumAgentVersion": "2.0.0", | ||
| "groups": [ | ||
| { |
There was a problem hiding this comment.
This group is not being used anywhere.
There was a problem hiding this comment.
This will be modified. This is just a placeholder right now.
Tasks/PackerBuild/tsconfig.json
Outdated
| "target": "ES6", | ||
| "module": "commonjs", | ||
| "sourceMap": true, | ||
| "sourceRoot": "E:\\github\\vsts-tasks\\Tasks\\PackerBuild" |
There was a problem hiding this comment.
Is this necessary? If yes, shouldn't it be relative?
There was a problem hiding this comment.
No this is not necessary. however, it provides easy reference to start debugging.
There was a problem hiding this comment.
on further thinking, may be I will remove this - it is better to have every ennggr his own way
| "storage_account": "{{user `storage_account`}}", | ||
| "subscription_id": "{{user `subscription_id`}}", | ||
| "tenant_id": "{{user `tenant_id`}}", | ||
| "object_id": "{{user `object_id`}}", |
There was a problem hiding this comment.
Where are all these values coming from?
There was a problem hiding this comment.
these will come from SPN. Right now task.json does not have azure endpoint. However, I will add that later and then it will light up.
packer task UI changes + some misc fixes to run task in release
remove packer task from make-options
|
Merging as this has been code reviewed in codeflow |
Does not contains task input UI changes. Will be done separately.
Does not have L0 tests. Will add in next iteration.
Currently works only for windows VM image creation.
Name/description/readme/icon etc are placeholder. They will be updated later.