Recursive Copy Fix & MSdeploy Changes #3618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjgupta
approved these changes
Feb 16, 2017
kmkumaran
approved these changes
Feb 20, 2017
| @@ -153,4 +153,25 @@ export async function isMSDeployPackage(webAppPackage: string ) { | |||
| } | |||
| tl.debug("Is the package an msdeploy package : " + isParamFilePresent); | |||
| return isParamFilePresent; | |||
| } | |||
|
|
|||
| export function copyDirectory(sourceDirectory: string, destDirectory: string) { | |||
There was a problem hiding this comment.
As discussed, can you add L0 for this.
arjgupta
requested changes
Feb 21, 2017
| @@ -458,4 +458,13 @@ describe('AzureRmWebAppDeployment Suite', function() { | |||
| done(); | |||
| }); | |||
|
|
|||
| it('Validate webdeployment-common.utility.copyDirectory()', (done:MochaDone) => { | |||
There was a problem hiding this comment.
please add the same test in IISWebAppDeploymentOnMachineGroup task as well
There was a problem hiding this comment.
added L0 Test for IIS App Deploy
arjgupta
approved these changes
Feb 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.