Users/ajya/create physical path for va #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent1173
reviewed
Dec 22, 2016
| defer.resolve(tl.loc('Physicalpathalreadyexists')); | ||
| } | ||
| else if(response.statusCode === 404) { |
There was a problem hiding this comment.
can u add a debug log as, physical path doesn't exist, creating the path ?
mvvsubbu
reviewed
Dec 22, 2016
| @@ -87,5 +87,11 @@ | |||
| "loc.messages.UnknownFileEncodeError": "Unable to detect encoding of the file %s (typeCode: %s). Supported encodings are UTF-8 and UTF-16 LE.", | |||
| "loc.messages.ShortFileBufferError": "File buffer is too short to detect encoding type : %s", | |||
| "loc.messages.FailedToUpdateAzureRMWebAppConfigDetails": "Failed to update Web App config details. Error: %s", | |||
| "loc.messages.SuccessfullyUpdatedAzureRMWebAppConfigDetails": "Successfully updated Web App config details" | |||
| "loc.messages.SuccessfullyUpdatedAzureRMWebAppConfigDetails": "Successfully updated Web App config details", | |||
mvvsubbu
reviewed
Dec 22, 2016
| azureWebAppDetails = await azureRESTUtility.getAzureRMWebAppConfigDetails(endPoint, webAppName, resourceGroupName, deployToSlotFlag, slotName); | ||
| var virtualApplicationMappings = azureWebAppDetails.properties.virtualApplications; | ||
| var pathMappings = kuduUtility.getVirtualAndPhysicalPaths(virtualApplication, virtualApplicationMappings); | ||
| if("/site/wwwroot" != pathMappings[1]) { |
There was a problem hiding this comment.
compare with value when path is not created
mvvsubbu
approved these changes
Dec 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.