Improve sql azure deployment task errors handling #3263
Conversation
| } | ||
| catch [System.Exception] | ||
| else | ||
| { |
There was a problem hiding this comment.
If some Exception is raised here , We wont be returning result or exception trace in that case, right ?
There was a problem hiding this comment.
If anything during execution of command fails it will come as part of result.
|
|
||
| param( | ||
| [string]$command, | ||
| [bool] $failOnErr = $true |
There was a problem hiding this comment.
nit pick - we can have verbose name like failOnError
| @@ -722,6 +726,9 @@ function Parse-Exception($exception){ | |||
| $responseBody = $streamReader.ReadToEnd() | |||
| $streamReader.Close() | |||
| Write-Verbose "Exception message extracted from response $responseBody" | |||
| if($response.statusCode -eq 404){ | |||
There was a problem hiding this comment.
Do/Should We need to handle any othe rcase here like 500 etc ?
| @@ -202,12 +202,12 @@ Catch [System.Management.Automation.CommandNotFoundException] | |||
| Write-Host "3. Run Import-Module SQLPS on your agent Powershell prompt. (This step is not required on Powershell 3.0 enabled machines)" | |||
| } | |||
|
|
|||
| Write-Error ($_.Exception|Format-List -Force|Out-String) | |||
| Write-Error ($_.Exception.Message) | |||
There was a problem hiding this comment.
can we do like this - if exception.Message is not null and empty then write error.message but it is empty or null write full exception
| @@ -664,7 +664,9 @@ function Add-AzureSqlDatabaseServerFirewallRule | |||
| $parsedException = Parse-Exception($_.Exception) | |||
| if($parsedException) | |||
| { | |||
| throw $parsedException | |||
| Write-Verbose $parsedException | |||
There was a problem hiding this comment.
This can be within Parse-Exception.
| $ErrorActionPreference = 'Continue' | ||
| if( $psversiontable.PSVersion.Major -le 4) | ||
| { | ||
| $result = cmd.exe /c "`"$command`"" 2>&1 |
There was a problem hiding this comment.
We should be using the task lib tool runner for this.
| catch [System.Exception] | ||
| else | ||
| { | ||
| $result = cmd.exe /c "$command" 2>&1 |
| @@ -713,6 +713,7 @@ function Remove-AzureSqlDatabaseServerFirewallRule | |||
|
|
|||
| function Parse-Exception($exception){ | |||
| if($exception) { | |||
| Write-Verbose "Exception message - $($exception.ToString())" | |||
There was a problem hiding this comment.
Can you add L0 tests for validating various error scenarios
No description provided.