azurecli classic cert auth's service url picked from endpoint #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaljg
reviewed
Dec 14, 2016
| @@ -198,9 +199,9 @@ export class azureclitask { | |||
| } | |||
| } | |||
|
|
|||
| private static createPublishSettingFile(subscriptionName:string, subscriptionId:string, certificate:string, publishSettingFileName:string): void { | |||
| private static createPublishSettingFile(subscriptionName:string, subscriptionId:string, certificate:string, serviceManagementUrl:string, publishSettingFileName:string): void { | |||
| //writing the data to the publishsetting file | |||
There was a problem hiding this comment.
Just verify if serviceManagementUrl can have a terminal slash and if so, will it cause any issues.
There was a problem hiding this comment.
while making a call to azure, the azurecli removes the terminal slash. Thus it is not causing any errors.
here is a screenshot of a call to azure while using a publishsetting file with serviceManagementUrl having terminal slash
amaljg
reviewed
Dec 14, 2016
| @@ -130,8 +130,9 @@ export class azureclitask { | |||
| if (endpointAuth.scheme === "Certificate") { | |||
| var bytes = endpointAuth.parameters["certificate"]; | |||
| var subscriptionId:string = tl.getEndpointDataParameter(connectedService, "SubscriptionId", true); | |||
| var serviceManagementUrl:string = tl.getEndpointUrl(connectedService, false); | |||
| const publishSettingFileName:string = path.join(os.tmpdir() ,"subscriptions" + new Date().getTime() + ".publishsettings"); | |||
There was a problem hiding this comment.
Is the service endpoint URL always present - even for older endpoints which didn't allow selecting this URL? If not, see if we should fallback to the default URL.
There was a problem hiding this comment.
a default service URL used to be present in older endpoints. so we should be fine.
amaljg
reviewed
Dec 14, 2016
| const publishSettingFileName:string = path.join(os.tmpdir() ,"subscriptions" + new Date().getTime() + ".publishsettings"); | ||
| this.createPublishSettingFile(subscriptionName, subscriptionId, bytes, publishSettingFileName); | ||
| this.createPublishSettingFile(subscriptionName, subscriptionId, bytes, serviceManagementUrl, publishSettingFileName); | ||
| var resultOfToolExecution = tl.execSync("azure", "account import \"" + publishSettingFileName + "\""); |
amaljg
approved these changes
Dec 14, 2016
sachinma
approved these changes
Dec 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure-CLI classic cert based authentication's Service Management URL will be picked from endpoint.