Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to skip ptr in vstest #20663

Merged
merged 13 commits into from
Nov 19, 2024
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@
"loc.input.label.rerunMaxAttempts": "Maximum # of attempts",
"loc.input.help.rerunMaxAttempts": "Specify the maximum # of times a failed test should be retried. If a test passes before the maximum # of attempts is reached, it will not be rerun further.",
"loc.messages.VstestLocationDoesNotExist": "The location of 'vstest.console.exe' specified '%s' does not exist.",
"loc.input.label.donotPublishTestResults": "Disable publishing test results",
eswarnathp marked this conversation as resolved.
Show resolved Hide resolved
"loc.input.help.donotPublishTestResults": "If this option is turned on, test results won't be published as part of this task. Use Publish Test Results task instead",
"loc.messages.VstestFailedReturnCode": "VsTest task failed.",
"loc.messages.VstestPassedReturnCode": "VsTest task succeeded.",
"loc.messages.NoMatchingTestAssemblies": "No test assemblies found matching the pattern: %s.",
Expand Down
2 changes: 1 addition & 1 deletion Tasks/VsTestV3/Tests/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Tasks/VsTestV3/inputdatacontract.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export interface TestReportingSettings {
TestRunSystem : string;
TestSourceSettings : TestSourceSettings;
ExecutionStatusSettings : ExecutionStatusSettings;
DonotPublishTestResults : boolean;
}

export interface TestSelectionSettings {
Expand Down
2 changes: 1 addition & 1 deletion Tasks/VsTestV3/inputparser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ function getTestReportingSettings(inputDataContract : idc.InputDataContract) : i
inputDataContract.TestReportingSettings.TestResultsDirectory = resultsDir;
tl.debug("TestResultsFolder: " + resultsDir);
addResultsDirectoryToTelemetry(resultsDir);

inputDataContract.TestReportingSettings.DonotPublishTestResults = tl.getBoolInput('donotPublishTestResults');
inputDataContract.TestReportingSettings.TestSourceSettings = <idc.TestSourceSettings>{};
inputDataContract.TestReportingSettings.TestSourceSettings.PullRequestTargetBranchName = tl.getVariable('System.PullRequest.TargetBranch');
inputDataContract.TestReportingSettings.ExecutionStatusSettings = <idc.ExecutionStatusSettings>{};
Expand Down
2 changes: 1 addition & 1 deletion Tasks/VsTestV3/make.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"dest": "./"
},
{
"url": "https://testmanagementstore.z13.web.core.windows.net/testmanagementcontainer/28213918/TestAgent.zip",
"url": "https://testmanagementstore.z13.web.core.windows.net/testmanagementcontainer/29341948/TestAgent.zip",
"dest": "./Modules"
},
{
Expand Down
270 changes: 135 additions & 135 deletions Tasks/VsTestV3/package-lock.json

Large diffs are not rendered by default.

14 changes: 12 additions & 2 deletions Tasks/VsTestV3/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 3,
"Minor": 248,
"Patch": 2
"Minor": 249,
"Patch": 0
},
"demands": [
"vstest"
Expand Down Expand Up @@ -427,6 +427,16 @@
"helpMarkDown": "Opt in/out of publishing run level attachments.",
"groupName": "reportingOptions"
},
{
"name": "donotPublishTestResults",
"type": "boolean",
"label": "Disable publishing test results",
"defaultValue": "false",
"required": false,
"helpMarkDown": "If this option is turned on, test results won't be published as part of this task. Use Publish Test Results task instead",
"groupName": "reportingOptions",
"visibleRule": "runInParallel = false"
},
{
"name": "failOnMinTestsNotRun",
"type": "boolean",
Expand Down
14 changes: 12 additions & 2 deletions Tasks/VsTestV3/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 3,
"Minor": 248,
"Patch": 2
"Minor": 249,
"Patch": 0
},
"demands": [
"vstest"
Expand Down Expand Up @@ -427,6 +427,16 @@
"helpMarkDown": "ms-resource:loc.input.help.publishRunAttachments",
"groupName": "reportingOptions"
},
{
"name": "donotPublishTestResults",
"type": "boolean",
"label": "ms-resource:loc.input.label.donotPublishTestResults",
"defaultValue": "false",
"required": false,
"helpMarkDown": "ms-resource:loc.input.help.donotPublishTestResults",
"groupName": "reportingOptions",
"visibleRule": "runInParallel = false"
},
{
"name": "failOnMinTestsNotRun",
"type": "boolean",
Expand Down
4 changes: 2 additions & 2 deletions _generated/VsTestV3.versionmap.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Default|3.248.2
Node20_229_4|3.248.3
Default|3.249.0
Node20_229_4|3.249.1
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@
"loc.input.help.configuration": "Build configuration against which the tests should be reported. If you have defined a variable for configuration in your build task, use that here.",
"loc.input.label.publishRunAttachments": "Upload test attachments",
"loc.input.help.publishRunAttachments": "Opt in/out of publishing run level attachments.",
"loc.input.label.donotPublishTestResults": "Disable publishing test results",
"loc.input.help.donotPublishTestResults": "If this option is turned on, test results won't be published as part of this task. Use Publish Test Results task instead",
"loc.input.label.failOnMinTestsNotRun": "Fail the task if a minimum number of tests are not run.",
"loc.input.help.failOnMinTestsNotRun": "Selecting this option will fail the task if specified minimum number of tests is not run.",
"loc.input.label.minimumExpectedTests": "Minimum # of tests",
Expand Down
2 changes: 1 addition & 1 deletion _generated/VsTestV3/Tests/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions _generated/VsTestV3/inputdatacontract.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export interface TestReportingSettings {
TestRunSystem : string;
TestSourceSettings : TestSourceSettings;
ExecutionStatusSettings : ExecutionStatusSettings;
DonotPublishTestResults : boolean;
}

export interface TestSelectionSettings {
Expand Down
2 changes: 1 addition & 1 deletion _generated/VsTestV3/inputparser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ function getTestReportingSettings(inputDataContract : idc.InputDataContract) : i
inputDataContract.TestReportingSettings.TestResultsDirectory = resultsDir;
tl.debug("TestResultsFolder: " + resultsDir);
addResultsDirectoryToTelemetry(resultsDir);

inputDataContract.TestReportingSettings.DonotPublishTestResults = tl.getBoolInput('donotPublishTestResults');
inputDataContract.TestReportingSettings.TestSourceSettings = <idc.TestSourceSettings>{};
inputDataContract.TestReportingSettings.TestSourceSettings.PullRequestTargetBranchName = tl.getVariable('System.PullRequest.TargetBranch');
inputDataContract.TestReportingSettings.ExecutionStatusSettings = <idc.ExecutionStatusSettings>{};
Expand Down
2 changes: 1 addition & 1 deletion _generated/VsTestV3/make.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"dest": "./"
},
{
"url": "https://testmanagementstore.z13.web.core.windows.net/testmanagementcontainer/28213918/TestAgent.zip",
"url": "https://testmanagementstore.z13.web.core.windows.net/testmanagementcontainer/29341948/TestAgent.zip",
"dest": "./Modules"
},
{
Expand Down
Loading