Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate tasks [part 2] #20222

Merged
merged 11 commits into from
Aug 5, 2024
Merged

Conversation

aleksandrlevochkin
Copy link
Contributor

Task names:

  • AzureCloudPowerShellDeployment@1
  • AzureCloudPowerShellDeployment@2
  • AzureFileCopy@1
  • AzureFileCopy@2
  • AzureFileCopy@3
  • AzureFunctionOnKubernetes@0
  • AzureKeyVault@1
  • AzureNLBManagement@1
  • AzurePowerShell@2
  • AzurePowerShell@3
  • Docker@0
  • DuffleInstaller@0
  • FileTransform@1
  • GitHubRelease@0
  • HelmInstaller@0

Description: Marked the tasks as deprecated

Documentation changes required: Docs should update automatically

Attached related issue: AB#2149149

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@aleksandrlevochkin aleksandrlevochkin marked this pull request as ready for review July 30, 2024 09:06
@aleksandrlevochkin aleksandrlevochkin requested review from manolerazvan and a team as code owners July 30, 2024 09:06
@aleksandrlevochkin aleksandrlevochkin requested review from a team and removed request for a team July 30, 2024 09:07
@aleksandrlevochkin aleksandrlevochkin merged commit 3705c02 into master Aug 5, 2024
11 checks passed
@Penguinwizzard
Copy link
Member

My team has encountered some of these messages, and were interested in knowing more about the deprecations:

  • Why are the old tasks deprecated?
  • What benefits can we expect with the new tasks?
  • Have our runs using the old task versions accrued some particular risk before doing the update?
  • What's the timeline for disablement for the old tasks?

Is there any chance that the deprecation messages can be updated with some of this info, or a link to a place to find this info?

@aleksandrlevochkin
Copy link
Contributor Author

Hi @Penguinwizzard!

1 - Usually, a task is deprecated when a newer major version is available, or it is used for an obsolete service
2 and 3 - I think it depends on the task, which ones in particular do you have in mind?
4 - The deprecated tasks will be retired later, once their usage decreases. The removal date will be announced in advance

@Penguinwizzard
Copy link
Member

The one from this particular change that came up with my team was the AzureKeyVault@1 deprecation in favor of AzureKeyVault@2. The message we got, as defined in this PR, was

The AzureKeyVault@1 task is deprecated, please use the latest version of the AzureKeyVault task

I think that a better message would be something along the lines of

The AzureKeyVault@1 task is deprecated, due to an issue with handling encodings as detailed in #14259. Please migrate to AzureKeyVault@2 or later for continued support.

This way we get a bit of an idea about the proximate motivation for the change, an impression of the rough scale of work needed to evaluate the change (basically just validating that our secrets still decode as expected), and an indication that the benefit is not only continued support but also better handling of some edge cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants