[DownloadBuildArtifactsV0] Replace decompress-zip with extract-zip package #19569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriiBobreshev
approved these changes
Feb 22, 2024
ivanduplenskikh
approved these changes
Feb 23, 2024
DergachevE
approved these changes
Feb 23, 2024
manolerazvan
approved these changes
Feb 26, 2024
merlynomsft
reviewed
Feb 26, 2024
merlynomsft
approved these changes
Feb 26, 2024
…place-decompresszip-with-extract-zip
merlynomsft
reviewed
Mar 21, 2024
| #if NODE20 | ||
| tl.debug(`Using extract-zip package for extracting archive`); | ||
| extract(this.zipLocation, { dir: unzipLocation }).then(() => { | ||
| resolve(); |
There was a problem hiding this comment.
should this be return resolve() and return reject(...)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: DownloadBuildArtifactsV0
Description: Replace decompress-zip package with extract-zip package to avoid incapability issues with Node17+
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) https://mseng.visualstudio.com/AzureDevOps/_workitems/edit/2150886
https://mseng.visualstudio.com/AzureDevOps/_workitems/edit/2150886
Checklist: