Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication issue in AzurePowerShell task #19550

Merged

Conversation

v-schhabra
Copy link
Contributor

@v-schhabra v-schhabra commented Feb 15, 2024

Task name: AzurePowerShellV5

Description: Pipelines were persisting authentication token while using AzurePowerShellV5 task on Microsoft hosted and Self-Hosted agents.
Documentation changes required: (Y/N)

Added unit tests: (Y/N)

Attached related issue: (Y/N) https://dev.azure.com/mseng/AzureDevOps/_workitems/edit/2128050

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@v-schhabra v-schhabra requested review from manolerazvan and a team as code owners February 15, 2024 13:09
Copy link
Contributor

@onetocny onetocny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for reflecting my suggestions from previous PR. I have two more ideas for simplification. Please take a look.

@v-schhabra v-schhabra requested a review from onetocny February 19, 2024 10:07
Copy link
Contributor

@onetocny onetocny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added two minor comments.

@v-schhabra
Copy link
Contributor Author

Added two minor comments.

Changes are done as suggested.
Thanks

Copy link
Contributor

@onetocny onetocny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for reflecting my comments.

@PhilipsonJoseph PhilipsonJoseph merged commit a09e055 into microsoft:master Feb 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants